You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/04/20 12:15:55 UTC
[jira] Created: (MPLUGIN-110) Make easier to pass parameters into
MojoDescriptorExtractors
Make easier to pass parameters into MojoDescriptorExtractors
------------------------------------------------------------
Key: MPLUGIN-110
URL: http://jira.codehaus.org/browse/MPLUGIN-110
Project: Maven 2.x Plugin Tools
Issue Type: Task
Components: API
Affects Versions: 2.1
Reporter: Benjamin Bentmann
Both MPLUGIN-15 and MPLUGIN-101 require breaking changes to the {{MojoDescriptorExtractor}} interface in order to push down configuration from the Plugin Plugin into the extractors. Further enhancements might need more parameters, too, this does not scale.
We should move all method parameters into some bean such that the {{execute()}} methods reduces to:
{code:java}
List execute( MojoDescriptorExtractorRequest request )
{code}
This way, future additions to the bean will not break existing implementors of the interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MPLUGIN-110) Make easier to pass parameters into
MojoDescriptorExtractors
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MPLUGIN-110.
------------------------------
Resolution: Fixed
Fix Version/s: 2.5
Implemented PluginToolsRequest and DefaultPluginToolsRequest, and changed tools APIs to pass these instances through the MojoScanner and MojoDescriptorExtractor implementations. Also, modified the maven-plugin-plugin to construct and pass in the new request object.
I left the public methods in both MojoDescriptorExtractor and MojoScanner as deprecated, and delegating to the new versions where they are implemented, in case anybody other than the maven-plugin-plugin is using them.
> Make easier to pass parameters into MojoDescriptorExtractors
> ------------------------------------------------------------
>
> Key: MPLUGIN-110
> URL: http://jira.codehaus.org/browse/MPLUGIN-110
> Project: Maven 2.x Plugin Tools
> Issue Type: Task
> Components: API
> Affects Versions: 2.1
> Reporter: Benjamin Bentmann
> Assignee: John Casey
> Fix For: 2.5
>
>
> Both MPLUGIN-15 and MPLUGIN-101 require breaking changes to the {{MojoDescriptorExtractor}} interface in order to push down configuration from the Plugin Plugin into the extractors. Further enhancements might need more parameters, too, this does not scale.
> We should move all method parameters into some bean such that the {{execute()}} methods reduces to:
> {code:java}
> List execute( MojoDescriptorExtractorRequest request )
> {code}
> This way, future additions to the bean will not break existing implementors of the interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira