[jira] [Comment Edited] (KARAF-4313) karaf-maven-plugin should set x bit on assembly

["Krzysztof Sobkowiak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244936#comment-15244936 ] 

Krzysztof Sobkowiak edited comment on KARAF-4313 at 4/17/16 10:22 PM:
----------------------------------------------------------------------

I have just tested in in the current 4.0.5-SNAPSHOT and it doesn't work. The unix scripts in the zip are still not executable. 

{noformat}
kso@lenovo:~/work/projects/asf/karaf/karaf-master/assemblies/apache-karaf/target/apache-karaf-4.1.0-SNAPSHOT/bin$ ls -al
total 136
drwx------ 3 kso kso  4096 kwi 18 00:15 .
drwx------ 9 kso kso  4096 kwi 18 00:15 ..
-rw-rw-r-- 1 kso kso  9257 kwi 18 00:15 client
-rw-rw-r-- 1 kso kso  4256 kwi 18 00:15 client.bat
drwx------ 2 kso kso  4096 kwi 18 00:15 contrib
-rw-rw-r-- 1 kso kso 10405 kwi 18 00:15 instance
-rw-rw-r-- 1 kso kso  5125 kwi 18 00:15 instance.bat
-rw-rw-r-- 1 kso kso 15276 kwi 18 00:15 karaf
-rw-rw-r-- 1 kso kso 14299 kwi 18 00:15 karaf.bat
-rw-rw-r-- 1 kso kso  2090 kwi 18 00:15 setenv
-rw-rw-r-- 1 kso kso  2159 kwi 18 00:15 setenv.bat
-rw-rw-r-- 1 kso kso 10321 kwi 18 00:15 shell
-rw-rw-r-- 1 kso kso  4716 kwi 18 00:15 shell.bat
-rw-rw-r-- 1 kso kso  3883 kwi 18 00:15 start
-rw-rw-r-- 1 kso kso  2495 kwi 18 00:15 start.bat
-rw-rw-r-- 1 kso kso  3613 kwi 18 00:15 status
-rw-rw-r-- 1 kso kso  2448 kwi 18 00:15 status.bat
-rw-rw-r-- 1 kso kso  3608 kwi 18 00:15 stop
-rw-rw-r-- 1 kso kso  2444 kwi 18 00:15 stop.bat
{noformat}

But the code setting the permissions looks ok 

{code}
if (entryName.contains("/bin/") || (!usePathPrefix && entryName.startsWith("bin"))) {
    if (!entryName.endsWith(".bat")) {
        zipEntry.setUnixMode(0755);
     } else {
        zipEntry.setUnixMode(0644);
     }
}
{code}




was (Author: sobkowiak):
I have just tested in in the current 4.0.5-SNAPSHOT and it doesn't work. The unix scripts in the zip are still not executable. 

> karaf-maven-plugin should set x bit on assembly
> -----------------------------------------------
>
>                 Key: KARAF-4313
>                 URL: https://issues.apache.org/jira/browse/KARAF-4313
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 4.1.0, 4.0.5
>
>
> karaf-maven-plugin which sets the executable bit for unix scripts (e.g. bin/karaf) in the generated zip assembly (similar to tgz assembly)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)