[jira] [Commented] (MAPREDUCE-2988) Reenable TestLinuxContainerExecutor reflecting the current NM code.

["Vinod Kumar Vavilapalli (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119399#comment-13119399 ] 

Vinod Kumar Vavilapalli commented on MAPREDUCE-2988:
----------------------------------------------------

I added TestLinuxContainerExecutor to imitate the tests TestLinuxTaskController and Test*AsDifferentUser() from MRV1. It was running before it got broken during a refactor. These tests are not supposed to be run by the usual Jenkins setup because of the dependency on the binary. We can optionally run these tests by passing container-executor.path and container-executor.conf.dir from the command line pointing to a properly setup binary and configs. The workflow for these tests is:

{code}
// Compile the code with binary
mvn clean install -Dcontainer-executor.conf.dir=/home/testConf -Dmaven.test.skip.exec=true
// Set proper permissions on the binary
sudo chown root:mapred ./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/c/container-executor/container-executor
sudo chmod +s,o-rwx ./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/c/container-executor/container-executor
// Run the tests
mvn test -Dtest=TestLinuxContainerExecutor -DjobSubmitter=nobody -Dcontainer-executor.path=./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/c/container-executor/container-executor
{code}

Makes sense?

We can keep your mock tests, but I want the tests using the real binary too :)

Please let me know if you are willing to take care of this too or want to load it off. Thanks!
                
> Reenable TestLinuxContainerExecutor reflecting the current NM code. 
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2988
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2988
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, security, test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Eric Payne
>            Assignee: Robert Joseph Evans
>            Priority: Critical
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MR-2988.txt, MR-2988.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> TestLinuxContainerExecutor is currently disabled completely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira