You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Jason Lowe (JIRA)" <ji...@apache.org> on 2018/01/16 16:05:01 UTC

[jira] [Commented] (MAPREDUCE-7037) Possible dead code in CombineFileInputFormat

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327299#comment-16327299 ] 

Jason Lowe commented on MAPREDUCE-7037:
---------------------------------------

The array itself is not used, but the act of filling in the array appears to have side-effects that are important.  For example, {{rackToNodes}} appears to be initialized during the construction of the array.

 

> Possible dead code in CombineFileInputFormat
> --------------------------------------------
>
>                 Key: MAPREDUCE-7037
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7037
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Lior Regev
>            Priority: Minor
>              Labels: newbie
>
> I found that in the file:
> hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java:280
> There's a generation of OneFileInfo[] without using that array ever again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org