You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xumingming (via GitHub)" <gi...@apache.org> on 2025/10/28 09:28:18 UTC
[PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
xumingming opened a new pull request, #3519:
URL: https://github.com/apache/celeborn/pull/3519
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add correctness related sections in bug report and PR template.
### Why are the changes needed?
Currently there is no easy to tell which bug report/PR is correctness related, but correctness actually is the most important thing that users care.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#issuecomment-3456040933
Although I wrote: "Yes/No. (If yes, please add `correctness` label to this Pull Request).", but seems developer has no rights to add label for a PR, do you have any suggestion? @SteNicholas @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2469222308
##########
.github/ISSUE_TEMPLATE/bug_report.md:
##########
@@ -13,6 +13,10 @@ A clear and concise description of what the bug is.
### How to reproduce the bug?
Steps to reproduce the bug.
+## Is this a correctness bug?
Review Comment:
Reverted. @SteNicholas Do we have correctness label at JIRA side then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3519: [CELEBORN-2186] Add correctness related section to bug report and PR templates
URL: https://github.com/apache/celeborn/pull/3519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2469223677
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+## Is this PR solving a correctness bug?
Review Comment:
@RexXiong Good catch, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#issuecomment-3456759659
> Although I wrote: "Yes/No. (If yes, please add `correctness` label to this Pull Request).", but seems developer has no rights to add label for a PR, do you have any suggestion? @SteNicholas @RexXiong
Don't worry, the additional content in the PR template is already noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2470245671
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
+Yes/No. (If yes, please add `correctness` label to this Pull Request).
Review Comment:
```suggestion
<!-- Yes/No. Add `correctness` label for a correctness bugfix. -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2470258510
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
Review Comment:
```suggestion
### Does this PR resolve a correctness bug?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2468797460
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+## Is this PR solving a correctness bug?
Review Comment:
I think It's fine that Number signs(#) aligned with other heading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2468727700
##########
.github/ISSUE_TEMPLATE/bug_report.md:
##########
@@ -13,6 +13,10 @@ A clear and concise description of what the bug is.
### How to reproduce the bug?
Steps to reproduce the bug.
+## Is this a correctness bug?
Review Comment:
Revert this file change because we use JIRA ticket to manage issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2470239726
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
Review Comment:
Add two new line before `### Is this PR solving a correctness bug?`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#issuecomment-3465936536
Merged to main(v0.7.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2470245671
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
+Yes/No. (If yes, please add `correctness` label to this Pull Request).
Review Comment:
```suggestion
<!-- Yes/No. Add `correctness` label for solving a correctness bug. -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2470245671
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
+Yes/No. (If yes, please add `correctness` label to this Pull Request).
Review Comment:
```suggestion
<!-- Yes/No. Note: add `correctness` label for a correctness bugfix. -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2186] Add correctness related section to bug report and PR templates [celeborn]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on code in PR #3519:
URL: https://github.com/apache/celeborn/pull/3519#discussion_r2471982924
##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -12,11 +12,12 @@ Thanks for sending a pull request! Here are some tips for you:
### Why are the changes needed?
+### Is this PR solving a correctness bug?
+Yes/No. (If yes, please add `correctness` label to this Pull Request).
Review Comment:
@SteNicholas As we discussed, developers actually has no permission to set the label, how about:
```
Yes/No. (If yes, committer will add `correctness` label to this Pull Request).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org