You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Hyukjin Kwon <gu...@gmail.com> on 2016/04/23 05:56:54 UTC
Proposal of closing some PRs which at least one of committers
suggested so
Hi all,
I realised that there are many open PRs and it is somehow problematic after
the past discussion (
http://apache-spark-developers-list.1001551.n3.nabble.com/auto-closing-pull-requests-that-have-been-inactive-gt-30-days-td17208.html
).
I looked through them PR by PR and could make a list for PRs which is
suggested to be closed after filtering them with the keyword "close" and
"closed"
https://github.com/apache/spark/pull/7647
https://github.com/apache/spark/pull/8195
https://github.com/apache/spark/pull/8741
https://github.com/apache/spark/pull/8972
https://github.com/apache/spark/pull/9490
https://github.com/apache/spark/pull/10419
https://github.com/apache/spark/pull/10761
https://github.com/apache/spark/pull/11003
https://github.com/apache/spark/pull/11201
https://github.com/apache/spark/pull/11803
https://github.com/apache/spark/pull/12111
https://github.com/apache/spark/pull/12442
https://github.com/apache/spark/pull/12524 <- I am 100% not sure for this
one.
I assume (from the past discussion above) it is possible to close PRs by
committers.
Could those PRs maybe be closed if it makes sense?
Thanks!
Re: Proposal of closing some PRs which at least one of committers
suggested so
Posted by Reynold Xin <rx...@databricks.com>.
I pushed a commit to close all but the last one.
On Sat, Apr 23, 2016 at 2:08 AM, Sean Owen <so...@cloudera.com> wrote:
> Except for the last one I think they're closeable. We can't close any
> PR directly. It's possible to push an empty commit with comments like
> "Closes #xxxx" to make the ASF processes close them.
>
> I'd swear we have a script for this but it's not in the Spark project,
> and it used to be run regularly. It would generate messages like
> "Automated closing of PRs" and was triggered by text in the PRs like
> "do you mind closing this PR". I can't find where it is though. That
> would be ideal to run again.
>
> @pwendell am I crazy .. did you not make this script and even email
> about it? I've lost it somehow.
>
> On Sat, Apr 23, 2016 at 4:56 AM, Hyukjin Kwon <gu...@gmail.com> wrote:
> > Hi all,
> >
> > I realised that there are many open PRs and it is somehow problematic
> after
> > the past discussion
> > (
> http://apache-spark-developers-list.1001551.n3.nabble.com/auto-closing-pull-requests-that-have-been-inactive-gt-30-days-td17208.html
> ).
> >
> > I looked through them PR by PR and could make a list for PRs which is
> > suggested to be closed after filtering them with the keyword "close" and
> > "closed"
> >
> > https://github.com/apache/spark/pull/7647
> >
> > https://github.com/apache/spark/pull/8195
> >
> > https://github.com/apache/spark/pull/8741
> >
> > https://github.com/apache/spark/pull/8972
> >
> > https://github.com/apache/spark/pull/9490
> >
> > https://github.com/apache/spark/pull/10419
> >
> > https://github.com/apache/spark/pull/10761
> >
> > https://github.com/apache/spark/pull/11003
> >
> > https://github.com/apache/spark/pull/11201
> >
> > https://github.com/apache/spark/pull/11803
> >
> > https://github.com/apache/spark/pull/12111
> >
> > https://github.com/apache/spark/pull/12442
> >
> > https://github.com/apache/spark/pull/12524 <- I am 100% not sure for
> this
> > one.
> >
> >
> > I assume (from the past discussion above) it is possible to close PRs by
> > committers.
> >
> > Could those PRs maybe be closed if it makes sense?
> >
> >
> > Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
> For additional commands, e-mail: dev-help@spark.apache.org
>
>
Re: Proposal of closing some PRs which at least one of committers
suggested so
Posted by Sean Owen <so...@cloudera.com>.
Except for the last one I think they're closeable. We can't close any
PR directly. It's possible to push an empty commit with comments like
"Closes #xxxx" to make the ASF processes close them.
I'd swear we have a script for this but it's not in the Spark project,
and it used to be run regularly. It would generate messages like
"Automated closing of PRs" and was triggered by text in the PRs like
"do you mind closing this PR". I can't find where it is though. That
would be ideal to run again.
@pwendell am I crazy .. did you not make this script and even email
about it? I've lost it somehow.
On Sat, Apr 23, 2016 at 4:56 AM, Hyukjin Kwon <gu...@gmail.com> wrote:
> Hi all,
>
> I realised that there are many open PRs and it is somehow problematic after
> the past discussion
> (http://apache-spark-developers-list.1001551.n3.nabble.com/auto-closing-pull-requests-that-have-been-inactive-gt-30-days-td17208.html).
>
> I looked through them PR by PR and could make a list for PRs which is
> suggested to be closed after filtering them with the keyword "close" and
> "closed"
>
> https://github.com/apache/spark/pull/7647
>
> https://github.com/apache/spark/pull/8195
>
> https://github.com/apache/spark/pull/8741
>
> https://github.com/apache/spark/pull/8972
>
> https://github.com/apache/spark/pull/9490
>
> https://github.com/apache/spark/pull/10419
>
> https://github.com/apache/spark/pull/10761
>
> https://github.com/apache/spark/pull/11003
>
> https://github.com/apache/spark/pull/11201
>
> https://github.com/apache/spark/pull/11803
>
> https://github.com/apache/spark/pull/12111
>
> https://github.com/apache/spark/pull/12442
>
> https://github.com/apache/spark/pull/12524 <- I am 100% not sure for this
> one.
>
>
> I assume (from the past discussion above) it is possible to close PRs by
> committers.
>
> Could those PRs maybe be closed if it makes sense?
>
>
> Thanks!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org