[GitHub] [iceberg] rdblue commented on a diff in pull request #4688: Add Apache HTTPComponents Client copyright to runtime NOTICE files

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4688:
URL: https://github.com/apache/iceberg/pull/4688#discussion_r864957670


##########
flink/v1.14/flink-runtime/NOTICE:
##########
@@ -89,3 +89,14 @@ file:
 |
 | This product includes software developed at
 | The Apache Software Foundation (http://www.apache.org/).
+
+--------------------------------------------------------------------------------
+
+This binary artifact includes Apache HTTPComponents Client with the following
+in its NOTICE file:

Review Comment:
   Of the dependency is another ASF project and has a boilerplate NOTICE file (like this one) we don't need to include it in the NOTICE file. We do need to make sure that we note it in the LICENSE file, though. Could you update this to add the standard LICENSE file content, @kbendick?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org