You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/21 02:12:00 UTC
[jira] [Commented] (YARN-11357) Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId
[ https://issues.apache.org/jira/browse/YARN-11357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621442#comment-17621442 ]
ASF GitHub Bot commented on YARN-11357:
---------------------------------------
slfan1989 opened a new pull request, #5055:
URL: https://github.com/apache/hadoop/pull/5055
JIRA: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId.
In [YARN-11342](https://issues.apache.org/jira/browse/YARN-11342), I refactored the submitApplication method, but in the process of implementation, the judgment condition of if was written incorrectly.
```
...
// Step2. Query homeSubCluster according to ApplicationId.
Boolean exists = existsApplicationHomeSubCluster(applicationId);
ApplicationHomeSubCluster appHomeSubCluster =
ApplicationHomeSubCluster.newInstance(applicationId, subClusterId);
// should be !exists
if (exists || retryCount == 0){
addApplicationHomeSubCluster(applicationId, appHomeSubCluster);
}
else{
updateApplicationHomeSubCluster(subClusterId, applicationId, appHomeSubCluster);
}
```
> Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId
> ---------------------------------------------------------------------------
>
> Key: YARN-11357
> URL: https://issues.apache.org/jira/browse/YARN-11357
> Project: Hadoop YARN
> Issue Type: Bug
> Components: federation
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
>
> In YARN-11342, I refactored the submitApplication method, but in the process of implementation, the judgment condition of if was written incorrectly.
>
> ```
> // Step2. Query homeSubCluster according to ApplicationId.
> Boolean exists = existsApplicationHomeSubCluster(applicationId);
> ApplicationHomeSubCluster appHomeSubCluster =
> ApplicationHomeSubCluster.newInstance(applicationId, subClusterId);
> // should be !exists
> if (exists || retryCount == 0) {
> addApplicationHomeSubCluster(applicationId, appHomeSubCluster);
> } else {
> updateApplicationHomeSubCluster(subClusterId, applicationId, appHomeSubCluster);
> }
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org