[jira] [Commented] (KAFKA-5137) Controlled shutdown timeout message improvement

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997782#comment-15997782 ] 

ASF GitHub Bot commented on KAFKA-5137:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2932


> Controlled shutdown timeout message improvement
> -----------------------------------------------
>
>                 Key: KAFKA-5137
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5137
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.10.2.0
>            Reporter: Dustin Cote
>            Assignee: Umesh Chaudhary
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.11.0.0
>
>
> Currently if you fail during controlled shutdown, you can get a message that says the socket.timeout.ms has expired. This config actually doesn't exist on the broker. Instead, we should explicitly say if we've hit the controller.socket.timeout.ms or the request.timeout.ms as it's confusing to take action given the current message. I believe the relevant code is here:
> https://github.com/apache/kafka/blob/0.10.2/core/src/main/scala/kafka/server/KafkaServer.scala#L428-L454
> I'm also not sure if there's another timeout that could be hit here or another reason why IOException might be thrown. In the least we should call out those two configs instead of the non-existent one but if we can direct to the proper one that would be even better.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)