[GitHub] [superset] kasiazjc edited a comment on pull request #18784: feat(native-filters): Re-arrange controls in FilterBar

[GitBox <gi...@apache.org>]

kasiazjc edited a comment on pull request #18784:
URL: https://github.com/apache/superset/pull/18784#issuecomment-1043200706


   > > > That change was discussed with @kasiazjc - the purpose is to indicate that there is hidden content under the buttons and user can scroll down.
   > > 
   > > 
   > > But then when there's available content to the top wouldn’t be the same?
   > 
   > One thing we could do is to keep the scroll always visible when there is one or add some icon like arrows top/bottom or 3 dots to indicate that there is more content available scrolling top or bottom. I prefer to keep the scroll always visible.
   
   @michael-s-molina Placement of the buttons at the top and bottom are two separate issues/flows. You scroll from the top to bottom, so when you scroll down you probably remember that there is something at the top. It may not be on the other hand intuitive that you can scroll down especially when the content/field hidden behind the buttons at the bottom is not partially visible. 
   
   From the design perspective the way we have scroll bar implemented right now is the intuitive/universal option and looks much cleaner (also that's how it's implemented in browsers etc.). Also adding the gradient behind the bottom section, especially when it comes to the buttons, helps to make the design lighter and more intuitive without it being to blocky - another white block at the bottom, especially when user's screen is smaller, can clutter the page (we already have a lot of different sections, panels etc.). We can change the % of the gradient, but I think this solutions works best here. 
   
   You mentioned adding icons as indicators, but it's not as visually easy to understand as the gradient. Additionally we already have a lot of different icons and we found that a lot of times it is confusing to the users what those actually mean. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org