[GitHub] [logging-log4cxx] ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'

[GitBox <gi...@apache.org>]

ams-tschoening commented on issue #18: Conditionally exclude tests that require the external 'zip' or 'gzip'
URL: https://github.com/apache/logging-log4cxx/pull/18#issuecomment-586895077
 
 
   So what's the problem actually, are you not able to provide the necessary binaries for some reason or do you want to make tests more compatible with systems not having them by default?
   
   Like already said, SED, ZIP and GZIP can easily be provided on Windows, so maybe the better approach is to document that those are needed if not already the case. You didn't care about Java not being available for [socketservertestcase](https://github.com/apache/logging-log4cxx/pull/14/files/d0c6cae2e4ede3cc6530f4b5ac8f80732a6b08fc..b971dd0bba2c548539aefb60ca6b1ff0e2bbf10e#diff-4360b6f15ada2e89dcba704aecb337f4) as well. These binaries are required by many tests and excluding each of those doesn't feel right.
   
   I don't think we should do this and vote against merging this. Additionally, the SED-related exception should be removed as well if this doesn't get merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services