[GitHub] [kafka] guozhangwang commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

[GitBox <gi...@apache.org>]

guozhangwang commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r887185726


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -479,6 +485,26 @@ public void restore(final Map<TaskId, Task> tasks) {
         }
     }
 
+    private void updateStandbyPartitions(final Map<TaskId, Task> tasks,

Review Comment:
   I'm wondering if we can make this a more general rule, like:
   
   1) When reader is in Restore_Active state i.e. there are at least one (for sake of simplicity just say we happen to have exactly one) active task which needs restoration, say taskA; then taskA was paused, we should be able to transit to Update_Standby.
   2) When reader is in Update_Standby state, and there is one active task say taskA resumed; we should be able to transit to Restore_Active.
   
   I know for now it does not matter since we always pause all tasks with the current APIs, but this is extensible for finer-grained controls in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org