[jira] [Commented] (ARROW-15316) [R] Make a one-function pointer function

["Dragoș Moldovan-Grünfeld (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477167#comment-17477167 ] 

Dragoș Moldovan-Grünfeld commented on ARROW-15316:
--------------------------------------------------

Would there be a need to be specific in the name of the function with regards to the type of the pointer? - i.e. {{double}}. Are we likely to define equivalent functions for {{integer64}}, {{character}}, {{raw}} etc?
 

> [R] Make a one-function pointer function
> ----------------------------------------
>
>                 Key: ARROW-15316
>                 URL: https://issues.apache.org/jira/browse/ARROW-15316
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Jonathan Keane
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>
> In ARROW-15173 [PR|https://github.com/apache/arrow/pull/12062/files] we added backwards compatibly to pointers between R and Python where we use `external_pointer_addr_double()` with old python versions. We could take a number of the blocks like:
> {code}
>  if (pyarrow_version() >= pyarrow_version_pointers_changed) {
>     x$`_export_to_c`(schema_ptr)
>   } else {
>     x$`_export_to_c`(external_pointer_addr_double(schema_ptr))
>   }
> {code}
> to 
> {code}
> x$`_export_to_c`(backwards_compatible_pointer(schema_ptr))
> {code}
> with {{backwards_compatible_pointer}} including the if/else



--
This message was sent by Atlassian Jira
(v8.20.1#820001)