[GitHub] [accumulo] ctubbsii commented on a change in pull request #1191: Replace use of deprecated newInstance calls.

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1191: Replace use of deprecated newInstance calls.
URL: https://github.com/apache/accumulo/pull/1191#discussion_r292216375
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java
 ##########
 @@ -158,8 +159,8 @@ private static void verifyValidClassName(String confOption, String className,
       Class<?> requiredBaseClass) {
     try {
       ConfigurationTypeHelper.getClassInstance(null, className, requiredBaseClass);
-    } catch (ClassNotFoundException | InstantiationException | IllegalAccessException
-        | IOException e) {
+    } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | IOException
 
 Review comment:
   By coincidence, I was also working on this today. What I ended up doing was replacing a lot of these exceptions with their parent, `ReflectiveOperationException` to remove the redundancy, and to cover the additional ones thrown by the `getDeclaredConstructor().getInstance()` pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services