[GitHub] betodealmeida opened a new pull request #4623: Use granularity for time step in play slider

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #4623: Use granularity for time step in play slider
URL: https://github.com/apache/incubator-superset/pull/4623
 
 
   There was a bug in the play slider where the Druid time granularity was not correctly parsed. I added a new function called `parseTimeGrain` which takes care of all the granularity values defined in Superset, both for SQLAlchemy and Druid, including arbitrary units.
   
   ![slider](https://user-images.githubusercontent.com/1534870/37496985-e0ac75f0-2872-11e8-8568-f6a4d15190a4.gif)
   
   Note that currently the play slider is configured to **loop every 15 seconds** by default. With a small number of steps this doesn't work — in the video above we have 1 hour of data at 15 minute granularity, so each frame takes at least ~4 seconds. Should we change the default behavior so that each step is, eg, 0.5 seconds? This way the steps would have a constant speed, but the loop duration would vary depending on the range of data and granularity. (cc: @vylc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services