You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 06:39:24 UTC
[GitHub] [airflow] msumit opened a new pull request #16579: Redact conn secrets in webserver logs
msumit opened a new pull request #16579:
URL: https://github.com/apache/airflow/pull/16579
Found sensitive connection attributes in webserver logs while testing a connection from UI.
Before:
```
[2021-06-22 12:00:32,341] {base.py:80} INFO - Using connection to: id: VmAyCbqf. Host: https://www.httpbin.org/, Port: None, Schema: , Login: admin, Password: admin, extra: {'access_token': '123456', 'foo': 'bar'}
```
After:
```
[2021-06-22 12:04:14,162] {base.py:80} INFO - Using connection to: id: 4P0GvhP3. Host: https://www.httpbin.org/, Port: None, Schema: , Login: admin, Password: ***, extra: {'access_token': '***', 'foo': 'bar'}
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16579: Redact conn secrets in webserver logs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16579:
URL: https://github.com/apache/airflow/pull/16579#issuecomment-881196509
God call. Marked it as 2.1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16579: Redact conn secrets in webserver logs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16579:
URL: https://github.com/apache/airflow/pull/16579#issuecomment-881073296
Since `BaseHook.get_connection()` is public API, this should probably still be backported to 2.1. See #17021.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit merged pull request #16579: Redact conn secrets in webserver logs
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #16579:
URL: https://github.com/apache/airflow/pull/16579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #16579: Redact conn secrets in webserver logs
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #16579:
URL: https://github.com/apache/airflow/pull/16579#issuecomment-865784109
> Ah, yeah I'd changed it to only redact the Task logs.
>
> The other option would be to have the redact filter apply to all of the webserver logs, but that feels heavy weight.
>
> Is the Test Connection button available in 2.1 or is it new in main/2.2? Yup, just checked, new in 2.2.
Yeah, I too thought it to apply for all logs, but then it feels like overburdening web server, hence used specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org