You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/10 21:31:37 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1772: Improve tool tip for hold time in Monitor
ctubbsii commented on a change in pull request #1772:
URL: https://github.com/apache/accumulo/pull/1772#discussion_r520886460
##########
File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/table.ftl
##########
@@ -44,7 +44,7 @@
<th title="Key/value pairs over each instance, table or tablet.">Entries </th>
<th title="The number of Key/Value pairs inserted. (Note that deletes are considered inserted)">Ingest </th>
<th title="The number of key/value pairs returned to clients. (Not the number of scans)">Query </th>
- <th title="The amount of time that ingest operations are suspended while waiting for data to be written to disk.">Hold Time </th>
+ <th title="The amount of time live ingest (mutations, batch writer) is suspended while waiting for tserver memory to free up. Writes are attempting to exceed tserver.memory.maps.max">Hold Time </th>
Review comment:
I like the first sentence, but I suggest: `s/is suspended/has been suspended/`.
I'm not sure I understand what the second sentence is trying to say. It may not be necessary. Or maybe it would be simpler to say something about the tserver awaiting a flush / minc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org