You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airavata.apache.org by ma...@apache.org on 2019/06/21 14:25:01 UTC

[airavata-django-portal] branch master updated (b14450e -> 2ffaab9)

This is an automated email from the ASF dual-hosted git repository.

machristie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airavata-django-portal.git.


    from b14450e  AIRAVATA-2638 Send frontend errors to server for logging
     new 450bd2a  AIRAVATA-2990 Add close button to experiment tab
     new 2ffaab9  AIRAVATA-2990 scroll experiment tab into view

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../statistics/ExperimentStatisticsContainer.vue      | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)


[airavata-django-portal] 01/02: AIRAVATA-2990 Add close button to experiment tab

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

machristie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airavata-django-portal.git

commit 450bd2a1bd4e051a7742ebff9649d0b445d1e8e8
Author: Marcus Christie <ma...@apache.org>
AuthorDate: Fri Jun 21 10:20:07 2019 -0400

    AIRAVATA-2990 Add close button to experiment tab
---
 .../statistics/ExperimentStatisticsContainer.vue          | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue b/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
index 1e41f4b..f54a961 100644
--- a/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
+++ b/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
@@ -280,8 +280,17 @@
         <b-tab
           v-for="experimentDetail in experimentDetails"
           :key="experimentDetail.experimentId"
-          :title="experimentDetail.experimentName"
         >
+          <template slot="title">
+            {{ experimentDetail.experimentName }}
+            <b-link
+              @click="removeExperimentDetails(experimentDetail.experimentId)"
+              class="text-secondary"
+            >
+              <i class="fas fa-times"></i>
+              <span class="sr-only">Close experiment tab</span>
+            </b-link>
+          </template>
           <experiment-details-view :experiment="experimentDetail" />
         </b-tab>
       </b-tabs>
@@ -565,6 +574,10 @@ export default {
       return this.experimentDetails.findIndex(
         e => e.experimentId === experimentId
       );
+    },
+    removeExperimentDetails(experimentId) {
+      const index = this.getExperimentDetailsIndex(experimentId);
+      this.experimentDetails.splice(index, 1);
     }
   }
 };


[airavata-django-portal] 02/02: AIRAVATA-2990 scroll experiment tab into view

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

machristie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airavata-django-portal.git

commit 2ffaab97a073a7fac32f4968b6ef225af7cd470b
Author: Marcus Christie <ma...@apache.org>
AuthorDate: Fri Jun 21 10:24:51 2019 -0400

    AIRAVATA-2990 scroll experiment tab into view
---
 .../src/components/statistics/ExperimentStatisticsContainer.vue       | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue b/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
index f54a961..b29e188 100644
--- a/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
+++ b/django_airavata/apps/admin/static/django_airavata_admin/src/components/statistics/ExperimentStatisticsContainer.vue
@@ -558,6 +558,7 @@ export default {
         }).then(exp => {
           this.experimentDetails.push(exp);
           this.selectExperimentDetailsTab(experimentId);
+          this.scrollTabsIntoView();
         });
       }
     },
@@ -578,6 +579,9 @@ export default {
     removeExperimentDetails(experimentId) {
       const index = this.getExperimentDetailsIndex(experimentId);
       this.experimentDetails.splice(index, 1);
+    },
+    scrollTabsIntoView() {
+      this.$refs.tabs.$el.scrollIntoView();
     }
   }
 };