You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Prakash Khemani (Created) (JIRA)" <ji...@apache.org> on 2011/10/28 22:39:33 UTC
[jira] [Created] (HBASE-4696) HRegionThriftServer
HRegionThriftServer
-------------------
Key: HBASE-4696
URL: https://issues.apache.org/jira/browse/HBASE-4696
Project: HBase
Issue Type: Bug
Reporter: Prakash Khemani
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Jonathan Gray (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-4696:
---------------------------------
Issue Type: Improvement (was: Bug)
Marking as improvement since this is really further improvement to a new feature rather than a real bug fix.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141753#comment-13141753 ]
Hudson commented on HBASE-4696:
-------------------------------
Integrated in HBase-TRUNK #2397 (See [https://builds.apache.org/job/HBase-TRUNK/2397/])
HBASE-4696 HRegionThriftServer' might have to indefinitely do redirtects (jgray)
jgray :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139564#comment-13139564 ]
dhruba borthakur commented on HBASE-4696:
-----------------------------------------
+1 code looks good to me.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139066#comment-13139066 ]
Hadoop QA commented on HBASE-4696:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501369/HBASE-4696-v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -166 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.master.TestDefaultLoadBalancer
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/89//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/89//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/89//console
This message is automatically generated.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Jonathan Gray (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-4696:
---------------------------------
Fix Version/s: 0.94.0
Affects Version/s: 0.94.0
Release Note: RS embedded thrift server can have redirecting turned on/off with "hbase.regionserver.thrift.redirect" (default: false)
Status: Patch Available (was: Open)
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-4696:
-----------------------------------
Description:
HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
Either redirects should be turned off and the client should react to NotServingRegionExceptions.
Or somehow a flag should be set in the response telling the client to refresh its cache.
Environment: (was: HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
Either redirects should be turned off and the client should react to NotServingRegionExceptions.
Or somehow a flag should be set in the response telling the client to refresh its cache.)
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Prakash Khemani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138891#comment-13138891 ]
Prakash Khemani commented on HBASE-4696:
----------------------------------------
looks good to me. thanks.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Jonathan Gray (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-4696:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-4696:
-----------------------------------
Environment:
HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
Either redirects should be turned off and the client should react to NotServingRegionExceptions.
Or somehow a flag should be set in the response telling the client to refresh its cache.
Summary: HRegionThriftServer' might have to indefinitely do redirtects (was: HRegionThriftServer)
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Bug
> Environment: HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
> Reporter: Prakash Khemani
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Jonathan Gray (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray reassigned HBASE-4696:
------------------------------------
Assignee: Jonathan Gray
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4696) HRegionThriftServer' might have to
indefinitely do redirtects
Posted by "Jonathan Gray (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-4696:
---------------------------------
Attachment: HBASE-4696-v1.patch
Adds new "redirect" configuration option to HRegionThriftServer: {{hbase.regionserver.thrift.redirect}}
Default is false.
If this is false, then if the current regionserver does not have the specified region, an exception is thrown rather than auto-re-directing.
This also has another fix where it was using the encoded region name instead of the full binary region name.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the correct region server if it has landed on the wrong region-server. With this approach the smart-client will never get a NotServingRegionException and it will never be able to invalidate its cache. It will indefinitely send the request to the wrong region server and the wrong region server will always be redirecting it.
> Either redirects should be turned off and the client should react to NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira