[GitHub] surekhasaharan opened a new pull request #6888: Fix num_rows in sys.segments

[GitBox <gi...@apache.org>]

surekhasaharan opened a new pull request #6888: Fix num_rows in sys.segments
URL: https://github.com/apache/incubator-druid/pull/6888
 
 
   `num_rows` column of `sys.segments` was incorrectly reported for some case.  It happened because the `segmentMetadataInfo` in `DruidSchema` was not being updated properly in `setSegmentSignature` and the value was overwritten in `addSegments` when the segment had more than one replica. This PR fixes:
   * segmentMetadataInfo update in `DruidSchema`
   * Add `numRows` to `SegmentMetadataHolder` builder's constructor, so it's not overwritten
   * Rename `setSegmentSignature` to `setSegmentMetadataHolder` and fix it so nested map is appended instead of recreated
   * Replace `Map<String, Set<String>>` with `Set<String>` for num_replica

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org