[GitHub] [incubator-inlong] ywh19911024 commented on a change in pull request #2387: [INLONG-2346][Feature][InLong-Sort] Support avro and canal formats for sort sink

[GitBox <gi...@apache.org>]

ywh19911024 commented on a change in pull request #2387:
URL: https://github.com/apache/incubator-inlong/pull/2387#discussion_r807686964



##########
File path: inlong-sort/pom.xml
##########
@@ -63,6 +63,7 @@
         <pulsar.version>2.8.1</pulsar.version>
         <kafka.version>2.4.1</kafka.version>
         <lzo.core.version>1.0.6</lzo.core.version>
+        <avro.version>1.10.0</avro.version>

Review comment:
       这个可以删除了，没看到用的地方

##########
File path: inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/TableFormatUtils.java
##########
@@ -331,7 +343,7 @@ public static LogicalType deriveLogicalType(FormatInfo formatInfo) {
         } else if (formatInfo instanceof DateFormatInfo) {
             return new DateType();
         } else if (formatInfo instanceof TimestampFormatInfo) {
-            return new TimestampType();
+            return new TimestampType(DEFAULT_PRECISION_FOR_TIMESTAMP);

Review comment:
       这里判断下呢，大于等于3的统一设置成2，小于的按照formatInfo中的来




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org