[jira] [Commented] (PIG-3137) fix Piggybank test to not using /tmp dir

["Cheolsoo Park (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568760#comment-13568760 ] 

Cheolsoo Park commented on PIG-3137:
------------------------------------

[~dreambird], thank you very much for the patch. I have two suggestions:
* FileLocalizer.getTemporaryPath() is for generating random paths in Hadoop cluster (either it's local, mini cluster, or real cluster). So it makes sense to use FileLocalizer in TestAvroStorage where we need temp paths for test outputs. But in TestDBStorage, we need a temp dir for Hsqldb, so I don't think we want to use FileLocalizer there. Using a temporary path under build (e.g. contrib/piggybank/java/build/blah) would be better.
* You can control the root dir of FileLocalizer.getTemporaryPath() using the pig.temp.dir property. It would be nice if it's set to somewhere under the build directory, so temporary dirs can be deleted by ant clean.

Let me know what you think. Thanks!


                
> fix Piggybank test to not using /tmp dir
> ----------------------------------------
>
>                 Key: PIG-3137
>                 URL: https://issues.apache.org/jira/browse/PIG-3137
>             Project: Pig
>          Issue Type: Bug
>          Components: piggybank
>    Affects Versions: 0.11
>            Reporter: Johnny Zhang
>             Fix For: 0.12
>
>         Attachments: PIG-3137.patch.txt
>
>
> right now several Piggybank tests create directory under /tmp to store test data, the test could fail because user doesn't have permission to create directory under /tmp. It is better to move test data dir under build dir to avoid this problem.
> I will submit a patch soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira