You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/01 19:54:43 UTC
[GitHub] jmeter pull request #348: Removed LogFilter and associated uses.
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/348
Removed LogFilter and associated uses.
Also formatted JavaDocs in SessionFilter.
## Description
I was about to write some Spock tests for `LogFilter` but, apart from the file not having meaningfully changed since 2003, I can't see it being used anywhere online or in the code.
The docs even say:
> The LogFilter is intended to allow access log entries to be filtered by filename and regex, as well as allowing for the replacement of file extensions. However, it is not currently possible to configure this via the GUI, **so it cannot really be used**.
## Motivation and Context
Removing unused code or that of little value.
## How Has This Been Tested?
## Types of changes
- Cruft removal
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter remove_log_filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 728fb350448dc7c87e79c75edb2cd961f49508f2
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-01T19:47:49Z
Removed LogFilter and associated uses.
Also formatted JavaDocs in SessionFilter.
----
---
[GitHub] jmeter issue #348: Removed LogFilter and associated uses.
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/348
Happy for someone to show me how this is used and useful and I will close the PR and learn from it :)
---
[GitHub] jmeter issue #348: Removed LogFilter and associated uses.
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/348
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=h1) Report
> Merging [#348](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/4d8facc557fda5986837c3da3b2364350f08b368?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #348 +/- ##
===========================================
- Coverage 58.1% 58.02% -0.08%
+ Complexity 10111 10055 -56
===========================================
Files 1154 1152 -2
Lines 73961 73794 -167
Branches 7342 7313 -29
===========================================
- Hits 42972 42821 -151
+ Misses 28509 28502 -7
+ Partials 2480 2471 -9
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/protocol/http/util/accesslog/SessionFilter.java](https://codecov.io/gh/apache/jmeter/pull/348/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC91dGlsL2FjY2Vzc2xvZy9TZXNzaW9uRmlsdGVyLmphdmE=) | `72.22% <ø> (+1.31%)` | `11 <0> (ø)` | :arrow_down: |
| [...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/348/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh) | `72.97% <0%> (-5.41%)` | `9% <0%> (-1%)` | |
| [...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/348/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==) | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/348/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.38% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=footer). Last update [4d8facc...728fb35](https://codecov.io/gh/apache/jmeter/pull/348?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #348: Removed LogFilter and associated uses.
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/348
Yes it is picked up by the GUI there, but there isn't any way to configure it in the GUI (as confirmed by the docs) so I can't see how it's useful. The default constructor is blank thus I think it just wouldn't perform any filtering. I've tested loading a test plan with the old filter in there and when you run it just throws an exception, so it would just need editing by the user to fix.
---
[GitHub] jmeter issue #348: Removed LogFilter and associated uses.
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/348
Hi @ham1 ,
I never used this Access log sampler in JMeter .
But I think the classes you removed are used as possible implementations for filtering.
See:
- http://jmeter.apache.org/images/screenshots/accesslogsampler.png
So I think the class must be kept
Regards
---