You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by jackowaya <gi...@git.apache.org> on 2015/10/13 00:31:30 UTC
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
GitHub user jackowaya opened a pull request:
https://github.com/apache/nifi/pull/101
AbstractKiteProcessor.getSchema leaks file handles
Close file handles when reading schema from resources or paths in AbstractKiteProcessor.getSchema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackowaya/incubator-nifi schemaLeak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by rdblue <gi...@git.apache.org>.
Github user rdblue commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147560797
+1, thanks for fixing this @jackowaya!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-149059384
looks good - am merging. Sorry for the delay Alan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by jackowaya <gi...@git.apache.org>.
Github user jackowaya commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147557510
Yes. I screwed up making the commit message. It's https://issues.apache.org/jira/browse/NIFI-1035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by joey <gi...@git.apache.org>.
Github user joey commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147557410
+1, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by joey <gi...@git.apache.org>.
Github user joey commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147557461
Is there a JIRA associated with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by joey <gi...@git.apache.org>.
Github user joey commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147557969
No worries, it still looks good to me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: AbstractKiteProcessor.getSchema leaks file hand...
Posted by jackowaya <gi...@git.apache.org>.
Github user jackowaya commented on the pull request:
https://github.com/apache/nifi/pull/101#issuecomment-147557634
Just force pushed with a message that has the jira ID in it. Hopefully that doesn't screw anything up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---