You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "Jacob S. Barrett (JIRA)" <ji...@apache.org> on 2017/01/17 18:55:26 UTC

[jira] [Commented] (GEODE-2312) Hook rat into cmake build

    [ https://issues.apache.org/jira/browse/GEODE-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826605#comment-15826605 ] 

Jacob S. Barrett commented on GEODE-2312:
-----------------------------------------

In researching the use of rat in on the native sources I found that the command line interface is very limited compared to the Ant and Gradle integrated interface. 

The {{--exclude <wildard>}} option only matches the file name and not the full path, meaning you can't use '/foo/**' notation. You may only use "foo*" which would exclude any file that starts with foo in any directory.

The {{--exclude-file <regexs>}} option matches by regex against the file name only as well. Meaning that '/foo/.*' does not match anything, and "foo.*" would match all files with foo anywhere in the name in any directory.

In order to use rat from CMake we would need to write a wrapper to run it on each directory in the repository and combine the results or write a custom CLI interface that behaves more like the gradle and ant interfaces.

I would suggest looking for other file analysis tools more relevant to a native project.


> Hook rat into cmake build
> -------------------------
>
>                 Key: GEODE-2312
>                 URL: https://issues.apache.org/jira/browse/GEODE-2312
>             Project: Geode
>          Issue Type: Sub-task
>          Components: native client
>            Reporter: Anthony Baker
>
> We should invoke rat from the cmake build to ensure that all files have proper ASF headers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)