You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/06/30 03:01:30 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
AngersZhuuuu opened a new pull request, #1666:
URL: https://github.com/apache/incubator-celeborn/pull/1666
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Rename spark patch file name to make it more clear
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1666:
URL: https://github.com/apache/incubator-celeborn/pull/1666#issuecomment-1614057842
> Names change looks good to me. The patch content will need some modification. How about changing the content by the way?
Yea, changed,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1666:
URL: https://github.com/apache/incubator-celeborn/pull/1666#issuecomment-1614054958
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1666](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5dd6115) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/1fd8833756721291d62db5151a8b9ccb91ea2c66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1fd8833) will **decrease** coverage by `0.30%`.
> The diff coverage is `19.38%`.
```diff
@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 46.41% 46.11% -0.30%
==========================================
Files 161 161
Lines 9949 9984 +35
Branches 957 960 +3
==========================================
- Hits 4617 4603 -14
- Misses 5031 5078 +47
- Partials 301 303 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ommon/network/client/TransportResponseHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `65.37% <0.00%> (ø)` | |
| [...che/celeborn/common/network/protocol/PushData.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9QdXNoRGF0YS5qYXZh) | `20.00% <ø> (ø)` | |
| [...orn/common/network/protocol/PushDataHandShake.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9QdXNoRGF0YUhhbmRTaGFrZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...leborn/common/network/protocol/PushMergedData.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9QdXNoTWVyZ2VkRGF0YS5qYXZh) | `19.57% <ø> (ø)` | |
| [...celeborn/common/network/protocol/RegionFinish.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9SZWdpb25GaW5pc2guamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../celeborn/common/network/protocol/RegionStart.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9SZWdpb25TdGFydC5qYXZh) | `0.00% <ø> (ø)` | |
| [...va/org/apache/celeborn/common/write/PushState.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vd3JpdGUvUHVzaFN0YXRlLmphdmE=) | `60.00% <ø> (ø)` | |
| [...orn/common/meta/ShufflePartitionLocationInfo.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvU2h1ZmZsZVBhcnRpdGlvbkxvY2F0aW9uSW5mby5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...born/common/meta/WorkerPartitionLocationInfo.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvV29ya2VyUGFydGl0aW9uTG9jYXRpb25JbmZvLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.46% <0.00%> (ø)` | |
| ... and [5 more](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1666/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1666:
URL: https://github.com/apache/incubator-celeborn/pull/1666#issuecomment-1614053091
Names change looks good to me. The patch content will need some modification. How about changing the content by the way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX closed pull request #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #1666: [CELEBORN-753] Rename spark patch file name to make it more clear
URL: https://github.com/apache/incubator-celeborn/pull/1666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org