You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:43:16 UTC
[GitHub] [arrow] sanjibansg opened a new pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
sanjibansg opened a new pull request #12621:
URL: https://github.com/apache/arrow/pull/12621
This PR adds an owning version of Table in TableBatchReader and implements a `to_reader()` method to convert a table to RecordBatchReader in PyArrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1069545783
Benchmark runs are scheduled for baseline = bc2aa3dac5f821a68d5e059d8261e5ea3c411bca and contender = 1157e677f9ba3e6d5b203adde4756a2e4d178713. 1157e677f9ba3e6d5b203adde4756a2e4d178713 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d74a4db31ff40c1ac3ace0322d82af4...313ec92026014c15b9121c1d4b9681e0/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8d174791c11f4f28a09b006d20df8490...4abd27a6b5a24bf3b9fa769f92e3ac05/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e29eaac8ed44276846e1e2d7435a28f...da611f38a3a8427591f3eb851e78b5be/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8fd1f4cb35e24f70b2c8810ca0b06301...b4b179c30ad447e58698aa01b38a9fe1/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r825883538
##########
File path: python/pyarrow/table.pxi
##########
@@ -2009,6 +2009,24 @@ cdef class Table(_PandasConvertible):
result.append(pyarrow_wrap_batch(batch))
return result
+
+ def to_reader(self):
Review comment:
Also, we should add a quick C++ unit test as well (where we make sure to drop the table or move the table into the reader before using the reader)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r826895042
##########
File path: python/pyarrow/table.pxi
##########
@@ -2010,6 +2010,37 @@ cdef class Table(_PandasConvertible):
return result
+ def to_reader(self, max_chunksize=None, **kwargs):
+ """
+ Convert a Table to RecordBatchReader
+
+ Returns
+ -------
+ RecordBatchReader
+ """
+ cdef:
+ shared_ptr[CRecordBatchReader] c_reader
+ RecordBatchReader reader
+ shared_ptr[TableBatchReader] t_reader
+ t_reader = make_shared[TableBatchReader](self.sp_table)
+
+ if 'chunksize' in kwargs:
+ max_chunksize = kwargs['chunksize']
+ msg = ('The parameter chunksize is deprecated for '
+ 'pyarrow.Table.to_batches as of 0.15, please use '
+ 'the parameter max_chunksize instead')
+ warnings.warn(msg, FutureWarning)
Review comment:
IMO, we can drop `kwargs` and the backwards compatibility here, this is a new API
##########
File path: python/pyarrow/table.pxi
##########
@@ -2010,6 +2010,37 @@ cdef class Table(_PandasConvertible):
return result
+ def to_reader(self, max_chunksize=None, **kwargs):
+ """
+ Convert a Table to RecordBatchReader
+
+ Returns
+ -------
+ RecordBatchReader
+ """
+ cdef:
+ shared_ptr[CRecordBatchReader] c_reader
+ RecordBatchReader reader
+ shared_ptr[TableBatchReader] t_reader
+ t_reader = make_shared[TableBatchReader](self.sp_table)
+
+ if 'chunksize' in kwargs:
+ max_chunksize = kwargs['chunksize']
+ msg = ('The parameter chunksize is deprecated for '
+ 'pyarrow.Table.to_batches as of 0.15, please use '
+ 'the parameter max_chunksize instead')
+ warnings.warn(msg, FutureWarning)
+
+ if max_chunksize is not None:
+ c_max_chunksize = max_chunksize
Review comment:
nit: I don't think this extra assignment does anything (though maybe Cython requires it for some reason)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r825881861
##########
File path: cpp/src/arrow/table.cc
##########
@@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table)
}
}
+TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
+ : table_(*table.get()),
Review comment:
nit: would it work better to just call the other constructor instead of repeating it here, e.g. `... : TableBatchReader(*table.get()), owned_table_(std::move(table)) {}`
##########
File path: python/pyarrow/table.pxi
##########
@@ -2009,6 +2009,24 @@ cdef class Table(_PandasConvertible):
result.append(pyarrow_wrap_batch(batch))
return result
+
+ def to_reader(self):
Review comment:
Add a quick unit test? Also, add the `max_chunksize` argument like `to_batches`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1069545783
Benchmark runs are scheduled for baseline = bc2aa3dac5f821a68d5e059d8261e5ea3c411bca and contender = 1157e677f9ba3e6d5b203adde4756a2e4d178713. 1157e677f9ba3e6d5b203adde4756a2e4d178713 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d74a4db31ff40c1ac3ace0322d82af4...313ec92026014c15b9121c1d4b9681e0/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8d174791c11f4f28a09b006d20df8490...4abd27a6b5a24bf3b9fa769f92e3ac05/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e29eaac8ed44276846e1e2d7435a28f...da611f38a3a8427591f3eb851e78b5be/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8fd1f4cb35e24f70b2c8810ca0b06301...b4b179c30ad447e58698aa01b38a9fe1/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1069545783
Benchmark runs are scheduled for baseline = bc2aa3dac5f821a68d5e059d8261e5ea3c411bca and contender = 1157e677f9ba3e6d5b203adde4756a2e4d178713. 1157e677f9ba3e6d5b203adde4756a2e4d178713 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d74a4db31ff40c1ac3ace0322d82af4...313ec92026014c15b9121c1d4b9681e0/)
[Finished :arrow_down:0.63% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8d174791c11f4f28a09b006d20df8490...4abd27a6b5a24bf3b9fa769f92e3ac05/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e29eaac8ed44276846e1e2d7435a28f...da611f38a3a8427591f3eb851e78b5be/)
[Finished :arrow_down:0.81% :arrow_up:0.17%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8fd1f4cb35e24f70b2c8810ca0b06301...b4b179c30ad447e58698aa01b38a9fe1/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r828210282
##########
File path: python/pyarrow/table.pxi
##########
@@ -2009,6 +2009,24 @@ cdef class Table(_PandasConvertible):
result.append(pyarrow_wrap_batch(batch))
return result
+
+ def to_reader(self):
Review comment:
- Added a cpp test for owned version of table in `tablebatchreader`.
- Added a python test for `to_reader()` method in table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r826894393
##########
File path: cpp/src/arrow/table.cc
##########
@@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table)
}
}
+TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
+ : table_(*table.get()),
Review comment:
Huh, forgot about that. Oh well, it's only a short initializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12621:
URL: https://github.com/apache/arrow/pull/12621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1066480010
https://issues.apache.org/jira/browse/ARROW-15823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r826564450
##########
File path: cpp/src/arrow/table.cc
##########
@@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table)
}
}
+TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
+ : table_(*table.get()),
Review comment:
I thought of following this approach at first, but an error will be thrown in this case, as an initializer for a delegating constructor must appear alone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1069545783
Benchmark runs are scheduled for baseline = bc2aa3dac5f821a68d5e059d8261e5ea3c411bca and contender = 1157e677f9ba3e6d5b203adde4756a2e4d178713. 1157e677f9ba3e6d5b203adde4756a2e4d178713 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d74a4db31ff40c1ac3ace0322d82af4...313ec92026014c15b9121c1d4b9681e0/)
[Finished :arrow_down:0.63% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8d174791c11f4f28a09b006d20df8490...4abd27a6b5a24bf3b9fa769f92e3ac05/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e29eaac8ed44276846e1e2d7435a28f...da611f38a3a8427591f3eb851e78b5be/)
[Finished :arrow_down:0.81% :arrow_up:0.17%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8fd1f4cb35e24f70b2c8810ca0b06301...b4b179c30ad447e58698aa01b38a9fe1/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] philix commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
philix commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r827062781
##########
File path: cpp/src/arrow/table.cc
##########
@@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table)
}
}
+TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
+ : table_(*table.get()),
+ owned_table_(std::move(table)),
Review comment:
This should probably be declared before `table_` since `table_` is `*owned_table_`. It doesn't matter much now, but if another member that takes `Table &` were to be introduced here, it would have a `Table &` pointing to freed memory when everything is destroyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12621: ARROW-15823: [C++][Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#issuecomment-1069545783
Benchmark runs are scheduled for baseline = bc2aa3dac5f821a68d5e059d8261e5ea3c411bca and contender = 1157e677f9ba3e6d5b203adde4756a2e4d178713. 1157e677f9ba3e6d5b203adde4756a2e4d178713 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2d74a4db31ff40c1ac3ace0322d82af4...313ec92026014c15b9121c1d4b9681e0/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8d174791c11f4f28a09b006d20df8490...4abd27a6b5a24bf3b9fa769f92e3ac05/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9e29eaac8ed44276846e1e2d7435a28f...da611f38a3a8427591f3eb851e78b5be/)
[Finished :arrow_down:0.81% :arrow_up:0.17%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8fd1f4cb35e24f70b2c8810ca0b06301...b4b179c30ad447e58698aa01b38a9fe1/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r828091137
##########
File path: python/pyarrow/table.pxi
##########
@@ -2010,6 +2010,37 @@ cdef class Table(_PandasConvertible):
return result
+ def to_reader(self, max_chunksize=None, **kwargs):
+ """
+ Convert a Table to RecordBatchReader
+
+ Returns
+ -------
+ RecordBatchReader
+ """
+ cdef:
+ shared_ptr[CRecordBatchReader] c_reader
+ RecordBatchReader reader
+ shared_ptr[TableBatchReader] t_reader
+ t_reader = make_shared[TableBatchReader](self.sp_table)
+
+ if 'chunksize' in kwargs:
+ max_chunksize = kwargs['chunksize']
+ msg = ('The parameter chunksize is deprecated for '
+ 'pyarrow.Table.to_batches as of 0.15, please use '
+ 'the parameter max_chunksize instead')
+ warnings.warn(msg, FutureWarning)
Review comment:
Dropped the `kwargs`
##########
File path: python/pyarrow/table.pxi
##########
@@ -2010,6 +2010,37 @@ cdef class Table(_PandasConvertible):
return result
+ def to_reader(self, max_chunksize=None, **kwargs):
+ """
+ Convert a Table to RecordBatchReader
+
+ Returns
+ -------
+ RecordBatchReader
+ """
+ cdef:
+ shared_ptr[CRecordBatchReader] c_reader
+ RecordBatchReader reader
+ shared_ptr[TableBatchReader] t_reader
+ t_reader = make_shared[TableBatchReader](self.sp_table)
+
+ if 'chunksize' in kwargs:
+ max_chunksize = kwargs['chunksize']
+ msg = ('The parameter chunksize is deprecated for '
+ 'pyarrow.Table.to_batches as of 0.15, please use '
+ 'the parameter max_chunksize instead')
+ warnings.warn(msg, FutureWarning)
+
+ if max_chunksize is not None:
+ c_max_chunksize = max_chunksize
Review comment:
Removed the extra assignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12621: ARROW-15823: [Python] Add a method to convert a Table to a RecordBatchReader
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12621:
URL: https://github.com/apache/arrow/pull/12621#discussion_r828094561
##########
File path: cpp/src/arrow/table.cc
##########
@@ -601,6 +602,19 @@ TableBatchReader::TableBatchReader(const Table& table)
}
}
+TableBatchReader::TableBatchReader(std::shared_ptr<Table> table)
+ : table_(*table.get()),
+ owned_table_(std::move(table)),
Review comment:
Thanks for pointing that out! Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org