You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ffbin <gi...@git.apache.org> on 2015/08/04 05:59:50 UTC
[GitHub] flink pull request: Remove unwanted check null of input1 in Connec...
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/978
Remove unwanted check null of input1 in ConnectedDataStream
input1 is used in line 61.If input1 is null ,it will throw NullPointException in line 61.So check null of input1 after use input1 is unwanted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/978.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #978
----
commit 2bd917a905d75a7c9de4f039d78fdb0b8deb431e
Author: ffbin <86...@qq.com>
Date: 2015-08-04T03:30:58Z
Remove unwanted check null of input1 in ConnectedDataStream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove unwanted check null of input1 in Connec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/978
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Remove unwanted check null of input1 in Connec...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/978#issuecomment-127513965
Looks good :+1:
Input 1 is actually always not null, but input 2 can be null in case of the ConnectedIterativeDataStreams
I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---