You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2018/05/21 20:54:02 UTC
Review Request 67237: SENTRY-2239: Table rename cross database should
update Full snapshot correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67237/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena.
Bugs: sentry-2239
https://issues.apache.org/jira/browse/sentry-2239
Repository: sentry
Description
-------
When HMS updates when sentry is taking full snapshot, sentry will apply those events event though some of them are already included in full snapshot. Update the code, so when the table rename cross database, the full snapshot is updated correctly
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java c30d982
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 0322cc3
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java c6be80d
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java cbfdb94
Diff: https://reviews.apache.org/r/67237/diff/1/
Testing
-------
TestDbPrivilegeCleanupOnDrop
TestSentryStore
TestFullUpdateModifier
Thanks,
Na Li
Re: Review Request 67237: SENTRY-2239: Table rename cross database
should update Full snapshot correctly
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67237/#review203519
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java
Line 363 (original)
<https://reviews.apache.org/r/67237/#comment285810>
Alter table should not be used to change database name for all tables in that database. Therefore, I remove this section.
- Na Li
On May 21, 2018, 8:54 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67237/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 8:54 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Bugs: sentry-2239
> https://issues.apache.org/jira/browse/sentry-2239
>
>
> Repository: sentry
>
>
> Description
> -------
>
> When HMS updates when sentry is taking full snapshot, sentry will apply those events event though some of them are already included in full snapshot. Update the code, so when the table rename cross database, the full snapshot is updated correctly
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java c30d982
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 0322cc3
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java c6be80d
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java cbfdb94
>
>
> Diff: https://reviews.apache.org/r/67237/diff/1/
>
>
> Testing
> -------
>
> TestDbPrivilegeCleanupOnDrop
> TestSentryStore
> TestFullUpdateModifier
>
>
> Thanks,
>
> Na Li
>
>