You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/03/20 18:35:29 UTC
Review Request 66177: Fixed flakiness in
ROOT_DOCKER_SlaveRecoveryTaskContainer test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66177/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benno Evers.
Bugs: MESOS-8258
https://issues.apache.org/jira/browse/MESOS-8258
Repository: mesos
Description
-------
The test was flaky due to ignoring only TASK_STARTING status update,
while TASK_RUNNING status update might appear if a task was launched
before the Docker executor re-registered. To fix the issue, this patch
ensures that both status updates are received.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e
Diff: https://reviews.apache.org/r/66177/diff/1/
Testing
-------
./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer --gtest_break_on_failure --gtest_repeat=100
Thanks,
Andrei Budnik
Re: Review Request 66177: Fixed flakiness in
ROOT_DOCKER_SlaveRecoveryTaskContainer test.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66177/#review199661
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 20, 2018, 6:35 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66177/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-8258
> https://issues.apache.org/jira/browse/MESOS-8258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to ignoring only TASK_STARTING status update,
> while TASK_RUNNING status update might appear if a task was launched
> before the Docker executor re-registered. To fix the issue, this patch
> ensures that both status updates are received.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e
>
>
> Diff: https://reviews.apache.org/r/66177/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66177: Fixed flakiness in
ROOT_DOCKER_SlaveRecoveryTaskContainer test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66177/#review199581
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66177']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66177
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66177/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (112 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1076 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (830 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (858 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (731 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (760 ms total)
[----------] Global test environment tear-down
[==========] 932 tests from 92 test cases ran. (666805 ms total)
[ PASSED ] 931 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 217 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66177/logs/mesos-tests-stderr.log):
```
I0320 20:55:04.926561 10336 master.cpp:10255] Updating the state of task 4ac2cc5d-6613-4b81-8dae-7f2d15e32ff8 of framework 2b3e275b-9301-446a-be03-401270921b9c-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0320 20:55:04.926561 9436 slave.cpp:3879] Shutting down framework 2b3e275b-9301-446a-be03-401270921b9c-0000
I0320 20:55:04.926561 9436 slave.cpp:6572] Shutting down executor '4ac2cc5d-6613-4b81-8dae-7f2d15e32ff8'I0320 20:55:04.742573 11872 exec.cpp:162] Version: 1.6.0
I0320 20:55:04.768553 12828 exec.cpp:236] Executor registered on agent 2b3e275b-9301-446a-be03-401270921b9c-S0
I0320 20:55:04.774556 11484 executor.cpp:176] Received SUBSCRIBED event
I0320 20:55:04.778583 11484 executor.cpp:180] Subscribed executor on win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0320 20:55:04.778583 11484 executor.cpp:176] Received LAUNCH event
I0320 20:55:04.783578 11484 executor.cpp:648] Starting task 4ac2cc5d-6613-4b81-8dae-7f2d15e32ff8
I0320 20:55:04.862592 11484 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0320 20:55:04.893566 11484 executor.cpp:661] Forked command at 12048
I0320 20:55:04.929564 5132 exec.cpp:445] Executor asked to shutdown
I0320 20:55:04.930567 11632 executor.cpp:176] Received SHUTDOWN event
I0320 20:55:04.930567 11632 executor.cpp:758] Shutting down
I0320 20:55:04.930567 11632 executor.cpp:868] Sending SIGTERM to process tree at pi of framework 2b3e275b-9301-446a-be03-401270921b9c-0000 at executor(1)@10.3.1.8:62434
I0320 20:55:04.928562 10336 master.cpp:10354] Removing task 4ac2cc5d-6613-4b81-8dae-7f2d15e32ff8 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 2b3e275b-9301-446a-be03-401270921b9c-0000 on agent 2b3e275b-9301-446a-be03-401270921b9c-S0 at slave(405)@10.3.1.8:60622 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 20:55:04.928562 9436 slave.cpp:925] Agent terminating
W0320 20:55:04.928562 9436 slave.cpp:3875] Ignoring shutdown framework 2b3e275b-9301-446a-be03-401270921b9c-0000 because it is terminating
I0320 20:55:04.930567 10336 master.cpp:1297] Agent 2b3e275b-9301-446a-be03-401270921b9c-S0 at slave(405)@10.3.1.8:60622 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0320 20:55:04.930567 10336 master.cpp:3278] Disconnecting agent 2b3e275b-9301-446a-be03-401270921b9c-S0 at slave(405)@10.3.1.8:60622 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 20:55:04.931560 972 hierarchical.cpp:344] Removed framework 2b3e275b-9301-446a-be03-401270921b9c-0000
I0320 20:55:04.932569 3324 containerizer.cpp:2338] Destroying container 2153757c-9414-4348-b43d-009911261531 in RUNNING state
I0320 20:55:04.932569 10336 master.cpp:3297] Deactivating agent 2b3e275b-9301-446a-be03-401270921b9c-S0 at slave(405)@10.3.1.8:60622 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0320 20:55:04.932569 3324 containerizer.cpp:2952] Transitioning the state of container 2153757c-9414-4348-b43d-009911261531 from RUNNING to DESTROYING
I0320 20:55:04.932569 9436 hierarchical.cpp:766] Agent 2b3e275b-9301-446a-be03-401270921b9c-S0 deactivated
I0320 20:55:04.932569 3324 launcher.cpp:156] Asked to destroy container 2153757c-9414-4348-b43d-009911261531
I0320 20:55:04.942574 8272 containerizer.cpp:2791] Container 2153757c-9414-4348-b43d-009911261531 has exited
I0320 20:55:04.974588 8580 master.cpp:1139] Master terminating
I0320 20:55:04.977591 3324 hierarchical.cpp:609] Removed agent 2b3e275b-9301-446a-be03-401270921b9c-S0
I0320 20:55:05.726613 13400 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 20, 2018, 6:35 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66177/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-8258
> https://issues.apache.org/jira/browse/MESOS-8258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to ignoring only TASK_STARTING status update,
> while TASK_RUNNING status update might appear if a task was launched
> before the Docker executor re-registered. To fix the issue, this patch
> ensures that both status updates are received.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e
>
>
> Diff: https://reviews.apache.org/r/66177/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 66177: Fixed flakiness in
ROOT_DOCKER_SlaveRecoveryTaskContainer test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66177/#review199623
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66177]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2018, 6:35 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66177/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 6:35 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-8258
> https://issues.apache.org/jira/browse/MESOS-8258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test was flaky due to ignoring only TASK_STARTING status update,
> while TASK_RUNNING status update might appear if a task was launched
> before the Docker executor re-registered. To fix the issue, this patch
> ensures that both status updates are received.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e
>
>
> Diff: https://reviews.apache.org/r/66177/diff/1/
>
>
> Testing
> -------
>
> ./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Andrei Budnik
>
>