You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/03/21 23:15:23 UTC
[Impala-ASF-CR] IMPALA-6704: Skip config validations in session-expiry-test.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9746
Change subject: IMPALA-6704: Skip config validations in session-expiry-test.
......................................................................
IMPALA-6704: Skip config validations in session-expiry-test.
Just like expr-test, we can skip config checking when creating
the InProcessImpalaServer in session-expiry-test. This fixes
an issue where the test would fail when there is no minicluster.
(The test itself would actually race and only fail sometimes,
on some machines.)
Testing: ran session-expiry-test.
Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
---
M be/src/service/session-expiry-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/9746/1
--
To view, visit http://gerrit.cloudera.org:8080/9746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Gerrit-Change-Number: 9746
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6704: Skip config validations in session-expiry-test.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9746 )
Change subject: IMPALA-6704: Skip config validations in session-expiry-test.
......................................................................
IMPALA-6704: Skip config validations in session-expiry-test.
Just like expr-test, we can skip config checking when creating
the InProcessImpalaServer in session-expiry-test. This fixes
an issue where the test would fail when there is no minicluster.
(The test itself would actually race and only fail sometimes,
on some machines.)
Testing: ran session-expiry-test.
Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Reviewed-on: http://gerrit.cloudera.org:8080/9746
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/session-expiry-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Gerrit-Change-Number: 9746
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6704: Skip config validations in session-expiry-test.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9746 )
Change subject: IMPALA-6704: Skip config validations in session-expiry-test.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2152/
--
To view, visit http://gerrit.cloudera.org:8080/9746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Gerrit-Change-Number: 9746
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 23:29:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6704: Skip config validations in session-expiry-test.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9746 )
Change subject: IMPALA-6704: Skip config validations in session-expiry-test.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Gerrit-Change-Number: 9746
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Mar 2018 03:12:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6704: Skip config validations in session-expiry-test.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9746 )
Change subject: IMPALA-6704: Skip config validations in session-expiry-test.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff6d4c2451ad26925dacfcdaa337b9e8d32c39d
Gerrit-Change-Number: 9746
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 23:25:40 +0000
Gerrit-HasComments: No