[jira] Commented: (SHIRO-96) Add meaningful integration tests to assert key web functionality

["Les Hazlewood (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHIRO-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751464#action_12751464 ] 

Les Hazlewood commented on SHIRO-96:
------------------------------------

I applied the patch - thanks very much!

I'll leave this issue open in case you have any more ;)

> Add meaningful integration tests to assert key web functionality
> ----------------------------------------------------------------
>
>                 Key: SHIRO-96
>                 URL: https://issues.apache.org/jira/browse/SHIRO-96
>             Project: Shiro
>          Issue Type: Test
>          Components: Authentication (log-in)
>    Affects Versions: 1.0
>         Environment: any
>            Reporter: Kalle Korhonen
>             Fix For: 1.0
>
>         Attachments: integration-tests.patch
>
>
> Related to SHIRO-93 (but you closed it already - could have re-opened as well). Assert login/logout and remember me functionality. Also updating htmlunit to newly released 2.6. Note that tests revealed an interesting thread-safety issue: sometimes getAuthorizationCache().get(upToken.getUsername()); on line 141 of SimpleAccountRealm returned null, causing the authentication to fail. It happened much frequently when I was running the test via Eclipse, but couldn't get it to run when running via Maven. I took an initial look at the CacheManager and didn't follow through completely, but it looked like that a map initialization somewhere may not have been synchronized. Note that these tests run considerably faster than if a human was using a browser but otherwise they don't semantically do anything else different. A patch to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.