You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/09 04:22:43 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #7707: Add test cases for sharding strategy

terrymanu opened a new issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707


   - [ ] Add test case for ShardingStrategyFactory
   - [ ] Add test case for StandardShardingStrategy
   - [ ] Add test case for ComplexShardingStrategy
   - [ ] Add test case for HintShardingStrategy
   - [ ] Add test case for NoneShardingStrategy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-706837570


   @jacksparrow414 Congrats! Do you think we can close this one?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-706164708


   - [x] Add test case for StandardShardingStrategy
   - [x] Add test case for ComplexShardingStrategy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705490935






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-706542994


   - [x] Add test case for HintShardingStrategy
   - [x] Add test case for NoneShardingStrategy
   
   All test cases are finished


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705959508


   Please do not use `Fixes #7707 .` If this PR does not fix the relevant issue, `Ref #7704` or `#7704` are recommended. Otherwise, the related issue will be closed with this PR merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 edited a comment on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 edited a comment on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705948897


   just finished the first one ,reopen this issue please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-707111356


   > @jacksparrow414 Congrats! Do you think we can close this one?
   
   yes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero edited a comment on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705959508


   @jacksparrow414  Please do not use `Fixes #7707 .` If this PR does not fix the relevant issue, `Ref #7704` or `#7704` are recommended. Otherwise, the related issue will be closed with this PR merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 edited a comment on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 edited a comment on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705948897


   just finished the first one ,reopen this issue please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero edited a comment on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705959508


   @jacksparrow414  Please do not use `Fixes #7707 .` If this PR does not fix the relevant issue, `Ref #7704` or `#7704` are recommended. Otherwise, the related issue will be closed with this PR merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705959508


   Please do not use `Fixes #7707 .` If this PR does not fix the relevant issue, `Ref #7704` or `#7704` are recommended. Otherwise, the related issue will be closed with this PR merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705948897


   only finshed first ,reopen please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705974770


   ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jacksparrow414 commented on issue #7707: Add test cases for sharding strategy

Posted by GitBox <gi...@apache.org>.
jacksparrow414 commented on issue #7707:
URL: https://github.com/apache/shardingsphere/issues/7707#issuecomment-705490935


   - [x] Add test case for ShardingStrategyFactory


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org