You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2022/08/01 19:33:13 UTC

[maven-shade-plugin] 01/01: [MSHADE-423] - Get rid of commons-lang3

This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch MSHADE-423
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git

commit bfef7c1308664397bd3130bb80ba4b352f6d3fc3
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Mon Aug 1 21:33:02 2022 +0200

    [MSHADE-423] - Get rid of commons-lang3
---
 pom.xml                                                         | 5 -----
 src/main/java/org/apache/maven/plugins/shade/DefaultShader.java | 5 ++---
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 942dd39..51371f0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -209,11 +209,6 @@
       <artifactId>jdependency</artifactId>
       <version>2.7.0</version>
     </dependency>
-    <dependency>
-      <groupId>org.apache.commons</groupId>
-      <artifactId>commons-lang3</artifactId>
-      <version>3.8.1</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-collections4</artifactId>
diff --git a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
index 6b032ca..e8505c5 100644
--- a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
+++ b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
@@ -55,7 +55,6 @@ import javax.inject.Singleton;
 
 import org.apache.commons.collections4.MultiValuedMap;
 import org.apache.commons.collections4.multimap.HashSetValuedHashMap;
-import org.apache.commons.lang3.StringUtils;
 import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugins.shade.filter.Filter;
 import org.apache.maven.plugins.shade.relocation.Relocator;
@@ -442,8 +441,8 @@ public class DefaultShader
             all.addAll( resources );
 
             logger.warn(
-                StringUtils.join( jarzS, ", " ) + " define " + all.size()
-                + " overlapping " + StringUtils.join( overlaps, " and " ) + ": " );
+                String.join( ", ", jarzS ) + " define " + all.size()
+                + " overlapping " + String.join( " and ", overlaps ) + ": " );
             //CHECKSTYLE_ON: LineLength
 
             Collections.sort( all );