You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/01 20:34:11 UTC

[jira] [Commented] (QUICKSTEP-20) Add parser support for SQL window aggregation function

    [ https://issues.apache.org/jira/browse/QUICKSTEP-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359584#comment-15359584 ] 

ASF GitHub Bot commented on QUICKSTEP-20:
-----------------------------------------

GitHub user shixuan-fan opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/49

    QUICKSTEP-20: Added ExecutionGenerator support for Window Aggregation

    - Created `WindowAggregationOperationState` and `WindowAggregationOperator`.
    - The execution generator could form an execution plan for window aggregation. Window aggregation operator takes the result of sorting as input, and output a relation with one extra attribute which is the result of window aggregation.
    - `WindowAggregationOperator::execute()` is a dummy method, it will report that window aggregation is not supported, and return an empty table based on the expected output relation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep SQL-window-aggregation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit c6ed1c3063289f61094366c178cd76c09157ceaf
Author: shixuan-fan <sh...@apache.org>
Date:   2016-06-29T20:25:18Z

    Created WindowAggregationOperator

commit 678d94dc306e9a85dc9b32f9d5a8f630a08ce78d
Author: shixuan-fan <sh...@apache.org>
Date:   2016-06-30T15:59:21Z

    Created WindowAggregationOperationState

commit 3a4eeb81056b4d7f01a6f8fe2dc815e75794b52c
Author: shixuan-fan <sh...@apache.org>
Date:   2016-06-30T16:33:27Z

    Added WindowAggregationOperationState in QueryContext

commit 1a83deecb866e977c9d0e3984e9a41139fa5fb12
Author: shixuan-fan <sh...@apache.org>
Date:   2016-06-30T21:52:39Z

    Added convertWindowAggregate() in ExecutionGenerator

commit f9d618a83fca6b97d5756b67d606597bcea9de3a
Author: shixuan-fan <sh...@apache.org>
Date:   2016-07-01T18:50:50Z

    Added dummy execute() method, window aggregate function will return an empty table with correct attributes

commit e17b35477277c41ef3e3dd431c47168e92c1eaba
Author: shixuan-fan <sh...@apache.org>
Date:   2016-07-01T19:19:23Z

    Minor comment modification

commit 7242806e753e262bc5016c8ff05040f5dbd1c053
Author: shixuan-fan <sh...@apache.org>
Date:   2016-07-01T20:12:13Z

    Added unittest

----


> Add parser support for SQL window aggregation function
> ------------------------------------------------------
>
>                 Key: QUICKSTEP-20
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-20
>             Project: Apache Quickstep
>          Issue Type: New Feature
>          Components: Parser
>            Reporter: Shixuan Fan
>              Labels: features, newbie
>
> The first part of window aggregation function. There will be new grammar introduced to the parser so that the parser could understand a window aggregation query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)