You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/04 21:22:18 UTC
[GitHub] [incubator-druid] gianm commented on issue #7392: Split
MetadataSegmentView in two implementations: caching and direct RPC call
gianm commented on issue #7392: Split MetadataSegmentView in two implementations: caching and direct RPC call
URL: https://github.com/apache/incubator-druid/issues/7392#issuecomment-508578691
I'm not sure if splitting this 1 thing into 3 things (interface + two concrete impls) makes it better. As one class with an `isCacheEnabled` flag it is pretty easy to understand. I suppose it might be somewhat nicer if done with a design like:
1. Non-caching impl exists and is super simple
2. Caching impl also exists, and contains a non-caching instance within itself, acting as sort of a caching wrapper
3. Both implement the same interface
Will reopen this issue / leave it open in case the conversation continues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org