You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vetrivel Chinnasamy <ve...@citrix.com> on 2014/07/30 09:00:54 UTC
Review Request 24090: Externalized the hard-coded strings from JavaScript
files to resource bundles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties a0205e1
client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
tools/ngui/static/js/app/storage/storage.js af36167
ui/dictionary.jsp 10aeaf9
ui/lib/flot/jquery.flot.pie.js b46c03c
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
ui/scripts/accounts.js 2ebfe82
ui/scripts/autoscaler.js c8963fd
ui/scripts/configuration.js 895f8e8
ui/scripts/domains.js 488382e
ui/scripts/events.js 2731cb6
ui/scripts/instances.js 93a40fc
ui/scripts/lbStickyPolicy.js 16995f6
ui/scripts/network.js b3a003d
ui/scripts/projects.js 53b7964
ui/scripts/regions.js 368c1bf
ui/scripts/sharedFunctions.js e8c4fcb
ui/scripts/storage.js f4ab6e1
ui/scripts/system.js 3b53df6
ui/scripts/templates.js 3e048cc
ui/scripts/ui-custom/autoscaler.js 0aa6c77
ui/scripts/ui-custom/healthCheck.js 4e10f1c
ui/scripts/ui-custom/physicalResources.js ac379b4
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui-custom/zoneWizard.js f3a1aae
ui/scripts/ui/dialog.js 0fddcf7
ui/scripts/ui/widgets/listView.js 22182c1
ui/scripts/ui/widgets/multiEdit.js 47e5f43
ui/scripts/vpc.js 83c5b83
ui/scripts/zoneWizard.js 0a84bdb
Diff: https://reviews.apache.org/r/24090/diff/
Testing
-------
Tested by replacing the modified javascript , dictionary.jsp and properties files.
Thanks,
Vetrivel Chinnasamy
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Mihaela Stoica <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/#review50338
-----------------------------------------------------------
Please see my comments on dictionary.jsp:
ui/dictionary.jsp
<https://reviews.apache.org/r/24090/#comment88024>
comma missing at the end of line
ui/dictionary.jsp
<https://reviews.apache.org/r/24090/#comment88023>
This entry should be 'label.add.ciscoASA1000v'
ui/dictionary.jsp
<https://reviews.apache.org/r/24090/#comment88026>
comma missing at the end of line
- Mihaela Stoica
On July 30, 2014, 8 a.m., Vetrivel Chinnasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24090/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 8 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties a0205e1
> client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
> client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
> tools/ngui/static/js/app/storage/storage.js af36167
> ui/dictionary.jsp 10aeaf9
> ui/lib/flot/jquery.flot.pie.js b46c03c
> ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
> ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
> ui/scripts/accounts.js 2ebfe82
> ui/scripts/autoscaler.js c8963fd
> ui/scripts/configuration.js 895f8e8
> ui/scripts/domains.js 488382e
> ui/scripts/events.js 2731cb6
> ui/scripts/instances.js 93a40fc
> ui/scripts/lbStickyPolicy.js 16995f6
> ui/scripts/network.js b3a003d
> ui/scripts/projects.js 53b7964
> ui/scripts/regions.js 368c1bf
> ui/scripts/sharedFunctions.js e8c4fcb
> ui/scripts/storage.js f4ab6e1
> ui/scripts/system.js 3b53df6
> ui/scripts/templates.js 3e048cc
> ui/scripts/ui-custom/autoscaler.js 0aa6c77
> ui/scripts/ui-custom/healthCheck.js 4e10f1c
> ui/scripts/ui-custom/physicalResources.js ac379b4
> ui/scripts/ui-custom/regions.js 986e009
> ui/scripts/ui-custom/zoneWizard.js f3a1aae
> ui/scripts/ui/dialog.js 0fddcf7
> ui/scripts/ui/widgets/listView.js 22182c1
> ui/scripts/ui/widgets/multiEdit.js 47e5f43
> ui/scripts/vpc.js 83c5b83
> ui/scripts/zoneWizard.js 0a84bdb
>
> Diff: https://reviews.apache.org/r/24090/diff/
>
>
> Testing
> -------
>
> Tested by replacing the modified javascript , dictionary.jsp and properties files.
>
>
> Thanks,
>
> Vetrivel Chinnasamy
>
>
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/#review52917
-----------------------------------------------------------
Vetri, I have a conflict in vpc.js...please rebase changes to the latest master and regenerate patch. Thanks.
error: patch failed: ui/scripts/vpc.js:698
error: ui/scripts/vpc.js: patch does not apply
Patch failed at 0001 Fixes: Externalized hardcoded strings and splitted up dictionary file
- Brian Federle
On Sept. 8, 2014, 11:43 a.m., Vetrivel Chinnasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24090/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2014, 11:43 a.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
> client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
> ui/dictionary.jsp 0102144
> ui/dictionary2.jsp PRE-CREATION
> ui/index.jsp 48afa6a
> ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
> ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
> ui/scripts/accounts.js cc4624a
> ui/scripts/autoscaler.js c8963fd
> ui/scripts/cloudStack.js 38cf501
> ui/scripts/configuration.js a70c672
> ui/scripts/domains.js 488382e
> ui/scripts/events.js 2731cb6
> ui/scripts/instances.js 4d536e3
> ui/scripts/lbStickyPolicy.js 16995f6
> ui/scripts/network.js 8a758c8
> ui/scripts/projects.js 53b7964
> ui/scripts/regions.js 368c1bf
> ui/scripts/sharedFunctions.js bb2d596
> ui/scripts/storage.js f4ab6e1
> ui/scripts/system.js cf3b9dc
> ui/scripts/templates.js 6dcd6da
> ui/scripts/ui-custom/autoscaler.js 0aa6c77
> ui/scripts/ui-custom/healthCheck.js 4e10f1c
> ui/scripts/ui-custom/physicalResources.js 110945e
> ui/scripts/ui-custom/regions.js 986e009
> ui/scripts/ui-custom/zoneWizard.js f3a1aae
> ui/scripts/ui/dialog.js 6c77924
> ui/scripts/ui/widgets/listView.js 22182c1
> ui/scripts/ui/widgets/multiEdit.js 47e5f43
> ui/scripts/vpc.js d3602fc
> ui/scripts/zoneWizard.js 4498534
>
> Diff: https://reviews.apache.org/r/24090/diff/
>
>
> Testing
> -------
>
> Tested by replacing the modified javascript , dictionary.jsp and properties files.
>
>
> Thanks,
>
> Vetrivel Chinnasamy
>
>
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/#review53742
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Sept. 12, 2014, 9:53 a.m., Vetrivel Chinnasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24090/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 9:53 a.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 4655973
> client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
> client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
> ui/dictionary.jsp 0102144
> ui/dictionary2.jsp PRE-CREATION
> ui/index.jsp 48afa6a
> ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
> ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
> ui/scripts/accounts.js cc4624a
> ui/scripts/autoscaler.js c8963fd
> ui/scripts/cloudStack.js 38cf501
> ui/scripts/configuration.js a70c672
> ui/scripts/domains.js 488382e
> ui/scripts/events.js 2731cb6
> ui/scripts/instances.js 4d536e3
> ui/scripts/lbStickyPolicy.js 16995f6
> ui/scripts/network.js 02dd269
> ui/scripts/projects.js 53b7964
> ui/scripts/regions.js 368c1bf
> ui/scripts/sharedFunctions.js 41f5d3a
> ui/scripts/storage.js f4ab6e1
> ui/scripts/system.js 54aafe2
> ui/scripts/templates.js 6dcd6da
> ui/scripts/ui-custom/autoscaler.js 0aa6c77
> ui/scripts/ui-custom/healthCheck.js 4e10f1c
> ui/scripts/ui-custom/physicalResources.js 110945e
> ui/scripts/ui-custom/regions.js 986e009
> ui/scripts/ui-custom/zoneWizard.js f3a1aae
> ui/scripts/ui/dialog.js 6c77924
> ui/scripts/ui/widgets/listView.js c7b4a4d
> ui/scripts/ui/widgets/multiEdit.js 47e5f43
> ui/scripts/vpc.js 786cb26
> ui/scripts/zoneWizard.js 4498534
>
> Diff: https://reviews.apache.org/r/24090/diff/
>
>
> Testing
> -------
>
> Tested by replacing the modified javascript , dictionary.jsp and properties files.
>
>
> Thanks,
>
> Vetrivel Chinnasamy
>
>
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
-----------------------------------------------------------
(Updated Sept. 12, 2014, 9:53 a.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Changes
-------
Fixed Conflict.
Repository: cloudstack-git
Description
-------
Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages.properties 4655973
client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
ui/dictionary.jsp 0102144
ui/dictionary2.jsp PRE-CREATION
ui/index.jsp 48afa6a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
ui/scripts/accounts.js cc4624a
ui/scripts/autoscaler.js c8963fd
ui/scripts/cloudStack.js 38cf501
ui/scripts/configuration.js a70c672
ui/scripts/domains.js 488382e
ui/scripts/events.js 2731cb6
ui/scripts/instances.js 4d536e3
ui/scripts/lbStickyPolicy.js 16995f6
ui/scripts/network.js 02dd269
ui/scripts/projects.js 53b7964
ui/scripts/regions.js 368c1bf
ui/scripts/sharedFunctions.js 41f5d3a
ui/scripts/storage.js f4ab6e1
ui/scripts/system.js 54aafe2
ui/scripts/templates.js 6dcd6da
ui/scripts/ui-custom/autoscaler.js 0aa6c77
ui/scripts/ui-custom/healthCheck.js 4e10f1c
ui/scripts/ui-custom/physicalResources.js 110945e
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui-custom/zoneWizard.js f3a1aae
ui/scripts/ui/dialog.js 6c77924
ui/scripts/ui/widgets/listView.js c7b4a4d
ui/scripts/ui/widgets/multiEdit.js 47e5f43
ui/scripts/vpc.js 786cb26
ui/scripts/zoneWizard.js 4498534
Diff: https://reviews.apache.org/r/24090/diff/
Testing
-------
Tested by replacing the modified javascript , dictionary.jsp and properties files.
Thanks,
Vetrivel Chinnasamy
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
-----------------------------------------------------------
(Updated Sept. 12, 2014, 9:42 a.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Changes
-------
Fixed the conflict.
Repository: cloudstack-git
Description
-------
Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages.properties 4655973
client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
ui/dictionary.jsp 0102144
ui/dictionary2.jsp PRE-CREATION
ui/index.jsp 48afa6a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
ui/scripts/accounts.js cc4624a
ui/scripts/autoscaler.js c8963fd
ui/scripts/cloudStack.js 38cf501
ui/scripts/configuration.js a70c672
ui/scripts/domains.js 488382e
ui/scripts/events.js 2731cb6
ui/scripts/instances.js 4d536e3
ui/scripts/lbStickyPolicy.js 16995f6
ui/scripts/network.js 02dd269
ui/scripts/projects.js 53b7964
ui/scripts/regions.js 368c1bf
ui/scripts/sharedFunctions.js 41f5d3a
ui/scripts/storage.js f4ab6e1
ui/scripts/system.js 54aafe2
ui/scripts/templates.js 6dcd6da
ui/scripts/ui-custom/autoscaler.js 0aa6c77
ui/scripts/ui-custom/healthCheck.js 4e10f1c
ui/scripts/ui-custom/physicalResources.js 110945e
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui-custom/zoneWizard.js f3a1aae
ui/scripts/ui/dialog.js 6c77924
ui/scripts/ui/widgets/listView.js c7b4a4d
ui/scripts/ui/widgets/multiEdit.js 47e5f43
ui/scripts/vpc.js 786cb26
ui/scripts/zoneWizard.js 4498534
Diff: https://reviews.apache.org/r/24090/diff/
Testing
-------
Tested by replacing the modified javascript , dictionary.jsp and properties files.
Thanks,
Vetrivel Chinnasamy
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
-----------------------------------------------------------
(Updated Sept. 8, 2014, 11:43 a.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Changes
-------
Splitted dictionary.jsp file to fix max size issue and reupdated the patch with other externalization modifications.
Repository: cloudstack-git
Description
-------
Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
ui/dictionary.jsp 0102144
ui/dictionary2.jsp PRE-CREATION
ui/index.jsp 48afa6a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
ui/scripts/accounts.js cc4624a
ui/scripts/autoscaler.js c8963fd
ui/scripts/cloudStack.js 38cf501
ui/scripts/configuration.js a70c672
ui/scripts/domains.js 488382e
ui/scripts/events.js 2731cb6
ui/scripts/instances.js 4d536e3
ui/scripts/lbStickyPolicy.js 16995f6
ui/scripts/network.js 8a758c8
ui/scripts/projects.js 53b7964
ui/scripts/regions.js 368c1bf
ui/scripts/sharedFunctions.js bb2d596
ui/scripts/storage.js f4ab6e1
ui/scripts/system.js cf3b9dc
ui/scripts/templates.js 6dcd6da
ui/scripts/ui-custom/autoscaler.js 0aa6c77
ui/scripts/ui-custom/healthCheck.js 4e10f1c
ui/scripts/ui-custom/physicalResources.js 110945e
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui-custom/zoneWizard.js f3a1aae
ui/scripts/ui/dialog.js 6c77924
ui/scripts/ui/widgets/listView.js 22182c1
ui/scripts/ui/widgets/multiEdit.js 47e5f43
ui/scripts/vpc.js d3602fc
ui/scripts/zoneWizard.js 4498534
Diff: https://reviews.apache.org/r/24090/diff/
Testing
-------
Tested by replacing the modified javascript , dictionary.jsp and properties files.
Thanks,
Vetrivel Chinnasamy
Re: Review Request 24090: Externalized the hard-coded strings from
JavaScript files to resource bundles.
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 10:11 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Repository: cloudstack-git
Description
-------
Externalized the hard-coded strings from JavaScript files to resource bundles. Updated the dictionary.jsp file accordingly. Also got the externalized strings translated in JA & SC.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties a0205e1
client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1
client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc
tools/ngui/static/js/app/storage/storage.js af36167
ui/dictionary.jsp 10aeaf9
ui/lib/flot/jquery.flot.pie.js b46c03c
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3
ui/scripts/accounts.js 2ebfe82
ui/scripts/autoscaler.js c8963fd
ui/scripts/configuration.js 895f8e8
ui/scripts/domains.js 488382e
ui/scripts/events.js 2731cb6
ui/scripts/instances.js 93a40fc
ui/scripts/lbStickyPolicy.js 16995f6
ui/scripts/network.js b3a003d
ui/scripts/projects.js 53b7964
ui/scripts/regions.js 368c1bf
ui/scripts/sharedFunctions.js e8c4fcb
ui/scripts/storage.js f4ab6e1
ui/scripts/system.js 3b53df6
ui/scripts/templates.js 3e048cc
ui/scripts/ui-custom/autoscaler.js 0aa6c77
ui/scripts/ui-custom/healthCheck.js 4e10f1c
ui/scripts/ui-custom/physicalResources.js ac379b4
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui-custom/zoneWizard.js f3a1aae
ui/scripts/ui/dialog.js 0fddcf7
ui/scripts/ui/widgets/listView.js 22182c1
ui/scripts/ui/widgets/multiEdit.js 47e5f43
ui/scripts/vpc.js 83c5b83
ui/scripts/zoneWizard.js 0a84bdb
Diff: https://reviews.apache.org/r/24090/diff/
Testing
-------
Tested by replacing the modified javascript , dictionary.jsp and properties files.
Thanks,
Vetrivel Chinnasamy