You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/18 20:19:58 UTC
Review Request 17088: Cache hashCode in generated immutable classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs: AURORA-58
https://issues.apache.org/jira/browse/AURORA-58
Repository: aurora
Description
-------
I've also silenced the code generator output by default, cleaning up the output when building via gradle.
Diffs
-----
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
Diff: https://reviews.apache.org/r/17088/diff/
Testing
-------
./gradlew build
I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
File Attachments
----------------
by_id_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
by_id_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
by_job_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
by_job_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
by_role_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
by_role_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
Thanks,
Bill Farner
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32253
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
<https://reviews.apache.org/r/17088/#comment60991>
Awesome! Finally, the clean build would perform to the expectation :)
- Maxim Khutornenko
On Jan. 18, 2014, 7:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17088/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-58
> https://issues.apache.org/jira/browse/AURORA-58
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I've also silenced the code generator output by default, cleaning up the output when building via gradle.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
>
> Diff: https://reviews.apache.org/r/17088/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
>
>
> File Attachments
> ----------------
>
> by_id_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
> by_id_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
> by_job_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
> by_job_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
> by_role_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
> by_role_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 23, 2014, 10:10 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py, line 427
> > <https://reviews.apache.org/r/17088/diff/1/?file=430129#file430129line427>
> >
> > parens on lhs are unnecessary here.
Fixed.
> On Jan. 23, 2014, 10:10 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py, line 427
> > <https://reviews.apache.org/r/17088/diff/1/?file=430129#file430129line427>
> >
> > parens on lhs are unnecessary here.
Double-fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32660
-----------------------------------------------------------
On Jan. 18, 2014, 7:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17088/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-58
> https://issues.apache.org/jira/browse/AURORA-58
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I've also silenced the code generator output by default, cleaning up the output when building via gradle.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
>
> Diff: https://reviews.apache.org/r/17088/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
>
>
> File Attachments
> ----------------
>
> by_id_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
> by_id_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
> by_job_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
> by_job_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
> by_role_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
> by_role_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32660
-----------------------------------------------------------
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
<https://reviews.apache.org/r/17088/#comment61566>
parens on lhs are unnecessary here.
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
<https://reviews.apache.org/r/17088/#comment61567>
parens on lhs are unnecessary here.
- Kevin Sweeney
On Jan. 18, 2014, 11:19 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17088/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 11:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-58
> https://issues.apache.org/jira/browse/AURORA-58
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I've also silenced the code generator output by default, cleaning up the output when building via gradle.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
>
> Diff: https://reviews.apache.org/r/17088/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
>
>
> File Attachments
> ----------------
>
> by_id_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
> by_id_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
> by_job_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
> by_job_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
> by_role_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
> by_role_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/
-----------------------------------------------------------
(Updated Jan. 23, 2014, 10:29 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Fixed parens. Thanks, submitting!
Bugs: AURORA-58
https://issues.apache.org/jira/browse/AURORA-58
Repository: aurora
Description
-------
I've also silenced the code generator output by default, cleaning up the output when building via gradle.
Diffs (updated)
-----
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py a321ccb62fe747aebfb930512dc73f14d8d1b5e7
Diff: https://reviews.apache.org/r/17088/diff/
Testing
-------
./gradlew build
I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
File Attachments
----------------
by_id_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
by_id_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
by_job_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
by_job_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
by_role_non_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
by_role_cached.png
https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
Thanks,
Bill Farner
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32503
-----------------------------------------------------------
Kevin — just waiting on a review from you.
- Bill Farner
On Jan. 18, 2014, 7:19 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17088/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-58
> https://issues.apache.org/jira/browse/AURORA-58
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I've also silenced the code generator output by default, cleaning up the output when building via gradle.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
>
> Diff: https://reviews.apache.org/r/17088/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
>
>
> File Attachments
> ----------------
>
> by_id_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
> by_id_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
> by_job_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
> by_job_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
> by_role_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
> by_role_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17088: Cache hashCode in generated immutable classes.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17088/#review32672
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 18, 2014, 11:19 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17088/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2014, 11:19 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-58
> https://issues.apache.org/jira/browse/AURORA-58
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I've also silenced the code generator output by default, cleaning up the output when building via gradle.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py ec3ac20ad9e81ace7db370fc54bed796b90758ca
>
> Diff: https://reviews.apache.org/r/17088/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
> I also did a quick benchmark using the yet-to-be-released storage benchmark. Graphs attached for before and after this change.
>
>
> File Attachments
> ----------------
>
> by_id_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/2d9aab73-4ae2-4b9d-bac1-8b0e5f893695__by_id_non_cached.png
> by_id_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d05f057e-7a88-496e-b65f-a0bd21190b71__by_id_cached.png
> by_job_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/e18e5c98-2ecd-4579-8f6a-7053b31c2019__by_job_non_cached.png
> by_job_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/59bed06f-f97f-4ea3-9a1d-aa670cb0d37f__by_job_cached.png
> by_role_non_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/d92fb94d-b69b-460f-8194-ea95834a5ac8__by_role_non_cached.png
> by_role_cached.png
> https://reviews.apache.org/media/uploaded/files/2014/01/18/89be7e97-87fa-4476-86f5-7720868a3964__by_role_cached.png
>
>
> Thanks,
>
> Bill Farner
>
>