You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/10/20 08:10:29 UTC
[PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Mryange opened a new pull request, #69331:
URL: https://github.com/apache/doris/pull/69331
### What problem does this PR solve?
Issue Number: N/A
Related PR: #63436
Problem Summary:
Backport #63436 to branch-4.1. TopN lazy materialization can hang when a join produces duplicate or out-of-order physical rowids. Root cause: reusing a column iterator for these requests can underflow the RLE decoder's unsigned skip count. Group rowids by segment, sort and deduplicate them before batch reads, then scatter the results back to preserve request order and duplicate rows.
The backport preserves branch-4.1 COW ownership, Variant V2 handling, rowid range checks, file cache policy, and existing external row-fetch fixes. The existing Variant segment-reader test is adapted to the batch interface. No additional prerequisite PRs are included.
### Release note
Fix TopN lazy materialization hanging on duplicate or out-of-order rowids from joins.
### Check List (For Author)
- Test:
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- BE ASAN clean build passed: `./build.sh --be --clean -j48`.
- clang-format 16 and `git diff --check` passed.
- Unit tests and SQL regression tests have not been run.
- Behavior changed:
- [ ] No.
- [x] Yes. Duplicate and out-of-order rowids are normalized before storage reads; output order and duplicates are preserved.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6333207368
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6286497321
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6294225255
# BE UT Coverage Report
Increment line coverage `15.87% (10/63)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/372719609707df77af19fab92179900638025abe_372719609707df77af19fab92179900638025abe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/372719609707df77af19fab92179900638025abe_372719609707df77af19fab92179900638025abe/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 61.48% (26981/43887) |
| Line Coverage | 46.15% (281256/609385) |
| Region Coverage | 41.81% (222691/532620) |
| Branch Coverage | 43.33% (103442/238734) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #69331:
URL: https://github.com/apache/doris/pull/69331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6333206755
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6294518731
# BE Regression && UT Coverage Report
Increment line coverage `96.83% (61/63)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/69331_372719609707df77af19fab92179900638025abe_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/69331_372719609707df77af19fab92179900638025abe_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 75.00% (32008/42677) |
| Line Coverage | 59.37% (358872/604503) |
| Region Coverage | 56.03% (299029/533677) |
| Branch Coverage | 56.95% (135778/238435) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Backport batched rowid reads for lazy materialization to 4.1 [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #69331:
URL: https://github.com/apache/doris/pull/69331#issuecomment-6286842842
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org