You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by co...@apache.org on 2022/12/19 10:12:01 UTC

[directory-kerby] branch trunk updated: vuln-fix: Temporary File Information Disclosure

This is an automated email from the ASF dual-hosted git repository.

coheigea pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/directory-kerby.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 76dafbaf vuln-fix: Temporary File Information Disclosure
     new a1e7144d Merge pull request #112 from BulkSecurityGeneratorProjectV2/fix/JLL/temporary_file_local_information_disclosure
76dafbaf is described below

commit 76dafbaf9a3b87c54e9bf44fd9da10bf3b1a4462
Author: Jonathan Leitschuh <Jo...@gmail.com>
AuthorDate: Sat Nov 19 02:09:43 2022 +0000

    vuln-fix: Temporary File Information Disclosure
    
    
    
    This fixes temporary file information disclosure vulnerability due to the use
    of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by
    using the `Files.createTempFile()` method which sets the correct posix permissions.
    
    Weakness: CWE-377: Insecure Temporary File
    Severity: Medium
    CVSSS: 5.5
    Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation)
    
    Reported-by: Jonathan Leitschuh <Jo...@gmail.com>
    Signed-off-by: Jonathan Leitschuh <Jo...@gmail.com>
    
    Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18
    
    
    Co-authored-by: Moderne <te...@moderne.io>
---
 .../kerberos/kerb/integration/test/JWTTokenTest.java     | 16 ++++++++--------
 .../kerb/integration/test/TokenLoginTestBase.java        |  3 ++-
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/JWTTokenTest.java b/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/JWTTokenTest.java
index 71b66da4..98b2772f 100644
--- a/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/JWTTokenTest.java
+++ b/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/JWTTokenTest.java
@@ -74,7 +74,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -138,7 +138,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -185,7 +185,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -232,7 +232,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -334,7 +334,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -393,7 +393,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -439,7 +439,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
@@ -484,7 +484,7 @@ public class JWTTokenTest extends TokenLoginTestBase {
         cCache.addCredential(credential);
         cCache.setPrimaryPrincipal(tgt.getClientPrincipal());
 
-        File cCacheFile = File.createTempFile("krb5_" + getClientPrincipal(), "cc");
+        File cCacheFile = Files.createTempFile("krb5_" + getClientPrincipal(), "cc").toFile();
         cCache.store(cCacheFile);
 
         KrbTokenClient tokenClient = new KrbTokenClient(client);
diff --git a/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/TokenLoginTestBase.java b/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/TokenLoginTestBase.java
index aedc0c53..5e74d2f7 100644
--- a/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/TokenLoginTestBase.java
+++ b/kerby-kerb/integration-test/src/test/java/org/apache/kerby/kerberos/kerb/integration/test/TokenLoginTestBase.java
@@ -36,6 +36,7 @@ import org.slf4j.LoggerFactory;
 
 import javax.security.auth.Subject;
 import java.io.File;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
@@ -58,7 +59,7 @@ public class TokenLoginTestBase extends LoginTestBase {
         armorCache = new File(getTestDir(), "armorcache.cc");
         tgtCache = new File(getTestDir(), "tgtcache.cc");
         signKeyFile = new File(this.getClass().getResource("/private_key.pem").getPath());
-        tokenCache = File.createTempFile("tokencache", null);
+        tokenCache = Files.createTempFile("tokencache", null).toFile();
     }
 
     @After