You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:00:40 UTC

[GitHub] [kafka] rajinisivaram opened a new pull request #9168: MINOR: Exclude scala-library from jacksonModuleScala for compile

rajinisivaram opened a new pull request #9168:
URL: https://github.com/apache/kafka/pull/9168


   We are forcing runtime scala-library dependency to be the one used by Kafka in https://github.com/apache/kafka/commit/3fdf1523a369e9e2f03e215f39c0ed987b2a16c5, but we still seem to include the version in jackson for compile. This PR explicitly excludes it. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rajinisivaram commented on pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #9168:
URL: https://github.com/apache/kafka/pull/9168#issuecomment-673144455


   @ijuma Thanks for the review, streams test failures not related. Merging to trunk, 2.6, 2,5 and 2.4.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rajinisivaram merged pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

Posted by GitBox <gi...@apache.org>.
rajinisivaram merged pull request #9168:
URL: https://github.com/apache/kafka/pull/9168


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rajinisivaram commented on pull request #9168: MINOR: Exclude scala-library from jacksonModuleScala for compile

Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #9168:
URL: https://github.com/apache/kafka/pull/9168#issuecomment-672922930


   @ijuma I have updated the PR using `configurations.all` that you suggested. Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #9168: MINOR: Exclude scala-library from jacksonModuleScala for compile

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9168:
URL: https://github.com/apache/kafka/pull/9168#discussion_r469256355



##########
File path: build.gradle
##########
@@ -716,7 +716,9 @@ project(':core') {
   dependencies {
     compile project(':clients')
     compile libs.jacksonDatabind
-    compile libs.jacksonModuleScala
+    compile(libs.jacksonModuleScala) {
+      exclude module: 'scala-library'

Review comment:
       Can we double check that jackson doesn't have a dependency on scala-reflect?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org