You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/10/21 02:37:45 UTC

[GitHub] jaylindquist opened a new pull request #3702: Add support for IE 11 for markup slices

jaylindquist opened a new pull request #3702: Add support for IE 11 for markup slices
URL: https://github.com/apache/incubator-superset/pull/3702
 
 
   - Add srcdoc-polyfill to support Internet Explorer iframes in markup slices: https://github.com/apache/incubator-superset/issues/3387
   - Add `allow-top-navigation` and `allow-popups` to support links within iframes: https://github.com/apache/incubator-superset/issues/3672
   
   Because srcdoc-polyfill uses a `javascript:` URL for the `src` attribute, the `allow-scripts` and `allow-same-origin` sandbox options need to be set, otherwise Internet Explorer will not be able to execute the script. This technically breaks all sandboxing as any javascript within the iframe can now manipulate the iframe element itself as well as any other element on the page.
   
   Added `allow-top-navigation` to support links in the markup slice with `target="_top"`
   
   Added `allow-popups` to support links in the markup slice with `target="_blank"`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services