You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/04 08:04:04 UTC

[GitHub] [apisix] moonming opened a new pull request #2356: bugfix: remove unsupported algorithm in jwt plugin.

moonming opened a new pull request #2356:
URL: https://github.com/apache/apisix/pull/2356


   support algorithm: https://github.com/SkyLothar/lua-resty-jwt/blob/master/lib/resty/jwt.lua#L505
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
    fix https://github.com/apache/apisix/issues/2325
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2356: bugfix: remove unsupported algorithm in jwt plugin.

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #2356:
URL: https://github.com/apache/apisix/pull/2356#discussion_r499259234



##########
File path: doc/plugins/jwt-auth.md
##########
@@ -20,11 +20,14 @@
 - [中文](../zh-cn/plugins/jwt-auth.md)
 
 # Summary
-- [**Name**](#name)
-- [**Attributes**](#attributes)
-- [**How To Enable**](#how-to-enable)
-- [**Test Plugin**](#test-plugin)
-- [**Disable Plugin**](#disable-plugin)
+- [Summary](#summary)
+  - [Name](#name)
+  - [Attributes](#attributes)
+  - [How To Enable](#how-to-enable)
+  - [Test Plugin](#test-plugin)
+      - [get the token in `jwt-auth` plugin:](#get-the-token-in-jwt-auth-plugin)
+      - [try request with token](#try-request-with-token)
+  - [Disable Plugin](#disable-plugin)

Review comment:
       revert the change. fixed 😃 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2356: bugfix: remove unsupported algorithm in jwt plugin.

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #2356:
URL: https://github.com/apache/apisix/pull/2356#discussion_r499223082



##########
File path: doc/plugins/jwt-auth.md
##########
@@ -20,11 +20,14 @@
 - [中文](../zh-cn/plugins/jwt-auth.md)
 
 # Summary
-- [**Name**](#name)
-- [**Attributes**](#attributes)
-- [**How To Enable**](#how-to-enable)
-- [**Test Plugin**](#test-plugin)
-- [**Disable Plugin**](#disable-plugin)
+- [Summary](#summary)
+  - [Name](#name)
+  - [Attributes](#attributes)
+  - [How To Enable](#how-to-enable)
+  - [Test Plugin](#test-plugin)
+      - [get the token in `jwt-auth` plugin:](#get-the-token-in-jwt-auth-plugin)
+      - [try request with token](#try-request-with-token)
+  - [Disable Plugin](#disable-plugin)

Review comment:
       Maybe we need to revert the auto-format




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming merged pull request #2356: bugfix: remove unsupported algorithm in jwt plugin.

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2356:
URL: https://github.com/apache/apisix/pull/2356


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2356: bugfix: remove unsupported algorithm in jwt plugin.

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2356:
URL: https://github.com/apache/apisix/pull/2356#discussion_r499243591



##########
File path: doc/plugins/jwt-auth.md
##########
@@ -20,11 +20,14 @@
 - [中文](../zh-cn/plugins/jwt-auth.md)
 
 # Summary
-- [**Name**](#name)
-- [**Attributes**](#attributes)
-- [**How To Enable**](#how-to-enable)
-- [**Test Plugin**](#test-plugin)
-- [**Disable Plugin**](#disable-plugin)
+- [Summary](#summary)
+  - [Name](#name)
+  - [Attributes](#attributes)
+  - [How To Enable](#how-to-enable)
+  - [Test Plugin](#test-plugin)
+      - [get the token in `jwt-auth` plugin:](#get-the-token-in-jwt-auth-plugin)
+      - [try request with token](#try-request-with-token)
+  - [Disable Plugin](#disable-plugin)

Review comment:
       Ok i didn't notice




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org