You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "talatuyarer (via GitHub)" <gi...@apache.org> on 2023/02/28 01:57:55 UTC

[GitHub] [beam] talatuyarer commented on pull request #25554: Backlog metrics do not showing up in FlinkRunner

talatuyarer commented on PR #25554:
URL: https://github.com/apache/beam/pull/25554#issuecomment-1447448279

   Hey @je-ik 
   
   > I wonder, why do we need to write metrics into the context on checkpoint? The current code does so in the call to `advance()`, is that not sufficient?
   
   Current code does not emit backlog metrics on advance. I see it is on checkpointing phase https://github.com/apache/beam/blob/master/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java#L255
   
   Do I miss anything ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org