You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Jungtaek Lim (JIRA)" <ji...@apache.org> on 2017/12/26 00:51:00 UTC

[jira] [Resolved] (STORM-2690) resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible

     [ https://issues.apache.org/jira/browse/STORM-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jungtaek Lim resolved STORM-2690.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.6
                   1.1.2
                   1.2.0
                   2.0.0

Thanks [~erikdw], I merged into master, 1.x, 1.1.x, 1.0.x branches.

> resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible
> ------------------------------------------------------------------------------------------
>
>                 Key: STORM-2690
>                 URL: https://issues.apache.org/jira/browse/STORM-2690
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 2.0.0, 1.1.0, 1.0.3, 1.0.4, 1.1.1, 1.1.2, 1.0.5
>            Reporter: Erik Weathers
>            Assignee: Erik Weathers
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.0.0, 1.2.0, 1.1.2, 1.0.6
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> As [discussed in STORM-2018|https://issues.apache.org/jira/browse/STORM-2018?focusedCommentId=16108307&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16108307], that change subtly broke the storm-mesos integration framework because of the removal of the invocation of [{{ISupervisor.assigned()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/scheduler/ISupervisor.java#L44].
> So this ticket is tracking the reinstatement of that invocation from the supervisor core code.
> Also, the [{{launchDaemon()}}|https://github.com/apache/storm/blob/v1.0.4/storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java#L248] method of the {{Supervisor}} is not public, so we had to use reflection to allow calling it from the storm-mesos integration.  That should be changed too.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)