You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2018/04/24 23:36:20 UTC
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10184
Change subject: Added changelog for 2.12.0
......................................................................
Added changelog for 2.12.0
Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
---
A docs/changelog-2.12.html
1 file changed, 541 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10184/1
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10184/1/docs/changelog-2.12.html
File docs/changelog-2.12.html:
http://gerrit.cloudera.org:8080/#/c/10184/1/docs/changelog-2.12.html@8
PS1, Line 8:
> Just for my information: This file is generated, right? These spaces in emp
Yes it is autogenerated, however, it's generated by JIRA automatically, so I'm not sure we can change that ourselves.
It's at the "Edit/Copy Release Notes" section in the bottom of this page:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321021&version=12342208
I manually trimmed the whitespaces now.
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 16:52:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 3: Code-Review+2
Carry +2. Thanks for the reviews!
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:28:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 4
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 18:30:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10184
to look at the new patch set (#2).
Change subject: Added changelog for 2.12.0
......................................................................
Added changelog for 2.12.0
Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
---
A docs/changelog-2.12.html
1 file changed, 541 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10184/2
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 2: Code-Review+1
Thx for the heads up!
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 16:57:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Added changelog for 2.12.0
Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Reviewed-on: http://gerrit.cloudera.org:8080/10184
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Sailesh Mukil <sa...@cloudera.com>
---
A docs/changelog-2.12.html
1 file changed, 541 insertions(+), 0 deletions(-)
Approvals:
Sailesh Mukil: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 5
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10184/1/docs/changelog-2.12.html
File docs/changelog-2.12.html:
http://gerrit.cloudera.org:8080/#/c/10184/1/docs/changelog-2.12.html@8
PS1, Line 8:
Just for my information: This file is generated, right? These spaces in empty lines is a bit disturbing the the review.
Do you know which script generates these? I might create a Jira to eliminate these spaces if you feel it makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Apr 2018 13:18:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Added changelog for 2.12.0
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 )
Change subject: Added changelog for 2.12.0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie78b1397623a5baac42e5bfd1b23f9234b76958b
Gerrit-Change-Number: 10184
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 16:59:36 +0000
Gerrit-HasComments: No