You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/02/25 13:59:50 UTC

[GitHub] [incubator-mxnet] anko-intel opened a new pull request #20915: Improve FC + add fusing

anko-intel opened a new pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915


   ## Description ##
   - Remove for_quantization flag from final graph,
   - Rename for_quantization flag to enable_fuse_add and simplify the logics,
   - Replace Node with BiDirectedNode to not fuse FC with elemwise add when
   FC output is used also as an input of other operator,
   - Do not fuse with add if already fused with other elemwise operation
   for quantized model.
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1058904709


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] anko-intel commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1054131065


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1055477311


   @mxnet-bot run ci [website]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1058201713


   Jenkins CI successfully triggered : [unix-cpu, website]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] anko-intel commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1058904640


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1050877026


   Hey @anko-intel , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, centos-cpu, edge, unix-gpu, sanity, unix-cpu, clang, website, miscellaneous, windows-cpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1054131103


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych merged pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] anko-intel commented on pull request #20915: Improve FC + add fusing

Posted by GitBox <gi...@apache.org>.
anko-intel commented on pull request #20915:
URL: https://github.com/apache/incubator-mxnet/pull/20915#issuecomment-1058201586


   @mxnet-bot run ci [unix-cpu, website]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org