You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/20 07:37:25 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #2952: Fix
some function DATE type priority
kangkaisen opened a new pull request #2952: Fix some function DATE type priority
URL: https://github.com/apache/incubator-doris/pull/2952
1. Fix the bug introduced by https://github.com/apache/incubator-doris/pull/2947.
The following sql result is 0000, which is wrong. The result should be 1601
```
select date_format('2020-02-19 16:01:12','%H%i');
```
2. Add constant Express plan test, ensure the FE constant Express compute result is right.
3. Remove the `castToInt ` function in `FEFunctions`, which is duplicated with `CastExpr::getResultValue`
4. Remove `selectStmt.getBaseTblResultExprs().set(i, slotRef);` to make the SQL plan could get the constant Express compute result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#2952: Fix some function DATE type priority
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2952: Fix some function DATE type priority
URL: https://github.com/apache/incubator-doris/pull/2952#discussion_r381953273
##########
File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -802,7 +802,6 @@ private PlanNode createConstantSelectPlan(SelectStmt selectStmt, Analyzer analyz
for (int i = 0; i < resultExprs.size(); ++i) {
SlotRef slotRef = new SlotRef(tupleDesc.getSlots().get(i));
resultExprs.set(i, slotRef);
- selectStmt.getBaseTblResultExprs().set(i, slotRef);
Review comment:
Has reverted this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2952: Fix some function
DATE type priority
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2952: Fix some function DATE type priority
URL: https://github.com/apache/incubator-doris/pull/2952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2952:
Fix some function DATE type priority
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2952: Fix some function DATE type priority
URL: https://github.com/apache/incubator-doris/pull/2952#discussion_r381828431
##########
File path: fe/src/test/java/org/apache/doris/utframe/ConstantExpressTest.java
##########
@@ -0,0 +1,130 @@
+package org.apache.doris.utframe;
Review comment:
license header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2952:
Fix some function DATE type priority
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2952: Fix some function DATE type priority
URL: https://github.com/apache/incubator-doris/pull/2952#discussion_r381830172
##########
File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -802,7 +802,6 @@ private PlanNode createConstantSelectPlan(SelectStmt selectStmt, Analyzer analyz
for (int i = 0; i < resultExprs.size(); ++i) {
SlotRef slotRef = new SlotRef(tupleDesc.getSlots().get(i));
resultExprs.set(i, slotRef);
- selectStmt.getBaseTblResultExprs().set(i, slotRef);
Review comment:
Is it OK when executing `insert into` statement?
I remember it seems to be introduced here in support of `insert into values()`. You can try if this patch works properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org