[GitHub] [spark] HyukjinKwon commented on a change in pull request #24237: [SPARK-27319][SQL] Filter out dir based on PathFilter before listing them

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24237: [SPARK-27319][SQL] Filter out dir based on PathFilter before listing them
URL: https://github.com/apache/spark/pull/24237#discussion_r271111798
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala
 ##########
 @@ -95,7 +96,7 @@ class FileIndexSuite extends SharedSQLContext {
       withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
         val fileIndex = new InMemoryFileIndex(spark, Seq(path), Map.empty, None)
         val partitionValues = fileIndex.partitionSpec().partitions.map(_.values)
-        assert(partitionValues.length == 2)
+        assert(partitionValues.length === 2)
 
 Review comment:
   That's not always the case (see https://github.com/databricks/scala-style-guide/issues/36). I heard that it can compare arrays properly as well. It would be great if we can document it there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org