You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 15:09:41 UTC

[GitHub] [nuttx] acassis commented on a diff in pull request #8129: net/tcp: correct behavior of SO_LINGER

acassis commented on code in PR #8129:
URL: https://github.com/apache/nuttx/pull/8129#discussion_r1071347684


##########
net/socket/Kconfig:
##########
@@ -43,7 +43,6 @@ config NET_SOLINGER
 	bool "SO_LINGER socket option"
 	default n
 	depends on NET_TCP_WRITE_BUFFERS || NET_UDP_WRITE_BUFFERS
-	select NET_TCP_NOTIFIER if NET_TCP
 	select NET_UDP_NOTIFIER if NET_UDP

Review Comment:
   Why didn't NET_TCP_NOTIFIER need to be selected?
   Could same be applied to NET_UDP_NOTIFIER later?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org